Server Crashed

[niemiecki216]

My server has been experiencing random crashes so I decided to run procdump on the process and wait until a crash is triggered. I ran the dump file produced from procdump and got the following

Unhandled exception at 0xc0000005

Running FXServer 6624 on Windows Server 2022

Link to download .dmp: https://drive.google.com/file/d/1j2n2NmNeAL7uzL_xpwOh25z47qw85pTS/view

[AvarianKnight]

This is a bit of a weird one, somehow dataLength is overflowing. Think figuring this one out is a bit over my head sadly.

fivem/code/components/citizen-resources-core/src/StateBagComponent.cpp

Lines 636 to 641 in b972aa2

	size_t dataLength = (buffer.GetLength() * 8) - buffer.GetCurrentBit();
	if (dataLength == 0)
	{
	return;
	}

[niemiecki216]

Is it due to too much data contained in the statebag?
And when the server crashes it immediately closes the fivem process without any message.

[gottfriedleibniz]

How state-bags are serialized is a bit rough, e.g., #1854 (comment). Even the edgiest of cases, e.g., key length serialized as a uint16_t but not being sanitized is worrisome.

One potential reproduction (works on my machine, YMMV):

    local BufferLimit = 131072
    local Overflow = 13

    local key = string.rep("y", BufferLimit + Overflow)
    local value = string.rep("\0", Overflow - 1)

    SetStateBagValue("global", key, value, #value, true)

[yellowcalvinn]

Hi, we are having the same problem on Linux Server. Random people crashing our server. Can we change it on linux?

[moelrobi]

Question: Is there an ETA when a new linux build will be released?

[tigerza117]

This is a bit of a weird one, somehow dataLength is overflowing. Think figuring this one out is a bit over my head sadly.

fivem/code/components/citizen-resources-core/src/StateBagComponent.cpp

Lines 636 to 641 in b972aa2

	size_t dataLength = (buffer.GetLength() * 8) - buffer.GetCurrentBit();
	if (dataLength == 0)
	{
	return;
	}

I have a question, how to debug like that, I run dump file in vs 2022 and got error

[AvarianKnight]

Add the symbol server https://runtime.fivem.net/client/symbols and have the repo setup on your machine

[tigerza117]

Thanks

[AvarianKnight]

This was fixed in #2161 and cleaned up further in #2185