Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migration from @effect/schema to effect monorepo package #522

Merged
merged 1 commit into from
Dec 15, 2024

Conversation

totto2727
Copy link
Contributor

@totto2727 totto2727 commented Dec 8, 2024

I have created a PR for the following Issue as I have not seen any progress on it.
If it has already been addressed, I will close it.

close #497

Changes

  • Delete @effect/schema
  • Upgrade effect package
  • Correction of import path

Local testing was successful.

Copy link

vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
superforms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 3:16pm

@ciscoheat
Copy link
Owner

Thank you, it's a good start, but there are typing problems with the adapter that I couldn't figure out easily. Maybe you know more about the new typing and can do it?

@totto2727
Copy link
Contributor Author

The test was inadequate...
Was not working on dev server...

The following fixes have been added

  • Import fixes
    • Added Either namespace to src/lib/adapters/effect.ts, removed Effect namespace
  • Fixed some type references.
    • src/lib/adapters/typeSchema.ts

Dev server and type checking confirmed that there are no problems.

@ciscoheat
Copy link
Owner

Great, I'll check it out locally soon, and if everything's fine I'll add it to the next release.

@ciscoheat ciscoheat merged commit fb0b7ad into ciscoheat:main Dec 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

effect adapter errors when using Schema from Effect
2 participants