Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for VineJs 2 #491

Closed
VL07 opened this issue Oct 23, 2024 · 2 comments
Closed

Support for VineJs 2 #491

VL07 opened this issue Oct 23, 2024 · 2 comments
Labels
adapter Related to validation adapters next Will be implemented in the next release

Comments

@VL07
Copy link

VL07 commented Oct 23, 2024

Considering VineJs 2.0.0 has been out since March, it would have been nice to have support for it in the VineJs adapter.

When I tried using VineJs 2 with the VineJs adapter I only got TS type errors, and the package.json for this project requires (peer dependency) version ^1.8.0. So to my understanding it's not currently supported.

You can still just use version 1.8.0 because it still has the same functionality. But I believe it would be good to mention this in the docs so you don't accedentally install the wrong version like I did.

@VL07 VL07 added the enhancement New feature or request label Oct 23, 2024
@ciscoheat ciscoheat added next Will be implemented in the next release adapter Related to validation adapters and removed enhancement New feature or request labels Nov 9, 2024
@ciscoheat
Copy link
Owner

Hopefully I can support both versions. Do you know if there are any breaking changes between the major versions that will affect how you use it with Superforms?

@ciscoheat
Copy link
Owner

What errors do you get? I'm testing with 2.0 and it works fine for me, so I'll just add it to the peer dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapter Related to validation adapters next Will be implemented in the next release
Projects
None yet
Development

No branches or pull requests

2 participants