Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

circusctl unable to set selected options #1162

Open
vdraceil opened this issue May 26, 2021 · 0 comments
Open

circusctl unable to set selected options #1162

vdraceil opened this issue May 26, 2021 · 0 comments

Comments

@vdraceil
Copy link

https://github.com/circus-tent/circus/blob/master/circus/watcher.py#L1081
set_opt does not handle bool options like "respawn" , "singleton" , etc.

I deployed my code to pre-production env (default respawn=True) and then I wanted to experiment with respawn=False as the processes get spawned out of control (because the celery children are not getting stopped when the parent bash script dies)
but I wasnt able to just update the config (runs in a kubernetes container) and re-test .. so had to use circusctl , but unfortunately I wasnt able to set respawn=False and test roght away

➜ circusctl set worker-1 respawn True
ok

➜ circusctl get worker-1 respawn
respawn: False

if the setting update needs a config reload or something, at least an err message would be great vs the misleading "ok" as if the update was successful

Same happens for "singleton" as well
well basically, it'll happen for all left out options in watcher.py::set_opt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant