From 8a33b75f55ba429e9e7a897179557aa8bb49ab35 Mon Sep 17 00:00:00 2001 From: Xin Chen Date: Tue, 19 Jul 2022 22:30:29 -0700 Subject: [PATCH] getModule API may return null module Summary: The native module might be null, and that should not be an exception thrown by the subclassed method. Changelog: [Android][Internal] - Mark getModule API to be nullable Reviewed By: mdvacca, makovkastar Differential Revision: D37900294 fbshipit-source-id: a4ecc9804b95bf0512554e96985f272b435e33b2 --- .../src/main/java/com/facebook/react/TurboReactPackage.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java b/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java index 0efffb9cff5454..8dc8ba5471b83f 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java +++ b/ReactAndroid/src/main/java/com/facebook/react/TurboReactPackage.java @@ -8,6 +8,7 @@ package com.facebook.react; import androidx.annotation.NonNull; +import androidx.annotation.Nullable; import com.facebook.react.bridge.ModuleHolder; import com.facebook.react.bridge.ModuleSpec; import com.facebook.react.bridge.NativeModule; @@ -42,7 +43,8 @@ public List createNativeModules(ReactApplicationContext reactConte * @param reactContext * @return */ - public abstract NativeModule getModule(String name, final ReactApplicationContext reactContext); + public abstract @Nullable NativeModule getModule( + String name, final ReactApplicationContext reactContext); /** * This is a temporary method till we implement TurboModules. Once we implement TurboModules, we