Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connectivity: single JUnit report for concurrent run #2689

Closed
viktor-kurchenko opened this issue Jul 16, 2024 · 2 comments · Fixed by #2707
Closed

connectivity: single JUnit report for concurrent run #2689

viktor-kurchenko opened this issue Jul 16, 2024 · 2 comments · Fixed by #2707
Assignees

Comments

@viktor-kurchenko
Copy link
Contributor

viktor-kurchenko commented Jul 16, 2024

Currently, if we run connectivity tests concurrently (using --test-concurrency flag) JUnit report will be created for each test namespace of K8S cluster.
I think it makes more sense to have a single JUnit report that collects all the data.

Run connectivity tests concurrently with JUnit report:

cilium connectivity test --test-concurrency=3 --junit-file report.xml

Single file JUnit report examples

@auriaave
Copy link

  1. can you provide the steps to reproduce this issue? Example: a command run and the list of files generated.
  2. can you provide an example of a single JUnit test where multiple tests run in sequence?
  3. is the expectation of this bug report to generate a single XML file?
    a. if so, have we asked for feedback from the people that consume the generated reports?
    b. what approach would you recommend? sending the output of a concurrent test via a channel for all inputs to be written on a single file?
  4. What would a single JUnit report file look like? Let's say 5 concurrent go-routines and some tests in one of the go-routines fails. Is the expectation that all tests will run and the single XML file will show the tests that failed? Or is it expected that as soon as a test fails (on any of the go-routines), no further tests will run?

Thank you!

@viktor-kurchenko
Copy link
Contributor Author

viktor-kurchenko commented Jul 18, 2024

@auriaave, thank you for your comments!

  1. The description updated with command example
  2. The description updated with single file JUnit reports
  3. I think we can treat this issue as improvement. I don't have much context on how we use JUnit reports (probably @brlbil has).
  4. It doesn't matter if test passes or fails, it just needs to be reflected in report (we should not change this logic).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants