Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decompose Cilium sysdump part into fine-grained components #2645

Closed
marseel opened this issue Jun 27, 2024 · 2 comments
Closed

Decompose Cilium sysdump part into fine-grained components #2645

marseel opened this issue Jun 27, 2024 · 2 comments
Labels
kind/enhancement This would improve or streamline existing functionality. stale

Comments

@marseel
Copy link
Contributor

marseel commented Jun 27, 2024

Proposal / RFE

Currently we either run all Cilium tasks or we don't run any:

if c.Options.CiliumNamespace != "" || c.Options.CiliumOperatorNamespace != "" {

Ideally, we would split these tasks into groups:

  • Cilium-agent tasks that are run only if we detect cilium-agent
  • Cilium-operator tasks that are run only if we detect cilium-operator
  • Cilium-generic tasks like collecting CRDs CNP/CCNP, Cilium configmaps etc that are always collected if any of Cilium stuff is detected
  • Hubble ...
  • Clustermesh ...
  • Envoy
  • ...

And have similar logic to

cilium-cli/sysdump/sysdump.go

Lines 1593 to 1601 in e04100b

tasks = append(tasks, c.getSPIRETasks()...)
}
if c.FeatureSet[features.GatewayAPI].Enabled {
tasks = append(tasks, c.getGatewayAPITasks()...)
}
if c.FeatureSet[features.EnableEnvoyConfig].Enabled {
tasks = append(tasks, c.getEnvoyConfigTasks()...)
}

This would allow us to report a bit more concise output of what was/wasn't detected at the beginning of running sysdump, something like:

Cilium components detected:

  • ✔️ Cilium Agent
  • 🟥 Cilium Operator
  • ✔️ Cilium CRDs detected: [...]
  • 🟥 Cilium CRDs not detected: [...]
  • ✔️ Hubble Relay
  • ⚠️ Clustermesh - detected clustermesh-apiserver deployment, but no running pods
  • ...

And then we wouldn't need to report all information for subtasks (like "Collecting ..." for things that don't exist) and only report ones that failed.

@marseel marseel added the kind/enhancement This would improve or streamline existing functionality. label Jun 27, 2024
Copy link

This issue has been automatically marked as stale because it has not
had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale label Sep 28, 2024
Copy link

This issue has not seen any activity since it was marked stale.
Closing.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This would improve or streamline existing functionality. stale
Projects
None yet
Development

No branches or pull requests

1 participant