Cleans up scrollTo's element finding #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces a somewhat convoluted query chain with a single querySelector to fetch the specific element we want to focus on. This feels slightly cleaner to my eyes, but has the added benefit of ensuring it works correctly with something like "vertical-collection", which occluding certain elements from the list for performance reasons. This was causing keyboard-navigation to fail unexpectedly, since `.item(19)` was no longer guaranteed to be the item with `data-option-index='19'`, or even to exist.
calvin-fb
approved these changes
Feb 9, 2022
|
Any thoughts on this @cibernox? |
|
If all test pass, It's way cleaner. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies the search for the option to scroll to, by querying directly for the element with the right index instead of fetching all elements and then selecting from the generated array.
This feels slightly cleaner to my eyes, and has the added benefit of ensuring it's not broken by something like vertical-collection, which only renders a sliding window of options for performance reasons. The combination was causing keyboard-navigation to fail unexpectedly, since
.item(19)was no longer guaranteed to be the item withdata-option-index='19', nor was the array guaranteed to be long enough to have that element.