Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate denoiser executable #35

Open
jackjt8 opened this issue Sep 22, 2022 · 1 comment
Open

Validate denoiser executable #35

jackjt8 opened this issue Sep 22, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jackjt8
Copy link
Member

jackjt8 commented Sep 22, 2022

Currently the Plugin does not check if the executable is the right one.

oidnDenoise.exe - Is correct and works.
oidnBenchmark.exe - Is invalid and only throws an Error: invalid argument in the debug console. Also locks up the Renderer.
oidnTest.exe - Is invalid and nothing happens.
DiskInfo64.exe - Is invalid and nothing happens.


Owing to how Chunky responded to oidnBenchmark.exe and Error: invalid argument I would recommend that we actually validate if the provided executable is the right one. Running oidnDenoise.exe or oidnDenoise.exe -h would show a list of valid command-line options.

D:\Programs\oidn-1.4.2.x64.vc14.windows\bin>oidnDenoise.exe
Intel(R) Open Image Denoise
usage: oidnDenoise [-d/--device default|cpu]
                   [-f/--filter RT|RTLightmap]
                   [--hdr color.pfm] [--ldr color.pfm] [--srgb] [--dir directional.pfm]
                   [--alb albedo.pfm] [--nrm normal.pfm] [--clean_aux]
                   [--is/--input_scale value]
                   [-o/--output output.pfm] [-r/--ref reference_output.pfm]
                   [-t/--type float|half]
                   [-w/--weights weights.tza]
                   [--threads n] [--affinity 0|1] [--maxmem MB] [--inplace]
                   [--bench ntimes] [-v/--verbose 0-3]
                   [-h/--help]

While the exact contents of the return may change we could still check and validate some of these results.

@leMaik leMaik added the enhancement New feature or request label Sep 22, 2022
@leMaik
Copy link
Member

leMaik commented Sep 25, 2023

Executing a random executable is a bad idea. We could check the hash, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants