Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 13 not working #3

Closed
schenkty opened this issue Jul 20, 2019 · 18 comments
Closed

iOS 13 not working #3

schenkty opened this issue Jul 20, 2019 · 18 comments

Comments

@schenkty
Copy link

What did you do?

I was testing my app on iOS 13 beta 4

What did you expect to happen?

I expected it work as it does on iOS 12

What happened instead?

The color section and sliders were all gray

@chrs1885
Copy link
Owner

Hi @schenkty, I haven‘t had the chance to to look into this, yet. But I will try to add iOS 13 support asap. I‘ll keep you in the loop once I‘ve figured out what the issue is. Are you planning to ship an app that is using the lib?

@schenkty
Copy link
Author

@chrs1885 Yes, the app currently has the lib implemented and is working for iOS 12.

@chrs1885
Copy link
Owner

What‘s the name of the app? Is it available on the App Store? Cheers!

@schenkty
Copy link
Author

@chrs1885 not available yet but the app name is called Linkz

@chrs1885
Copy link
Owner

@schenkty Unfortunately, there doesn‘t seem to be a fix for that right now. However, I‘m pretty sure that this issue will be addressed in the upcoming beta releases. Otherwise, I‘m gonna wrap the color picker inside a custom action sheet controller. Any thoughts on that?

@schenkty
Copy link
Author

What is the issue for it not working? It would probably work fine inside a custom action sheet controller if it has to be in one. I have had issues with other frameworks that use customer action sheet controllers where it doesn't work properly on iPads.

@chrs1885
Copy link
Owner

Exactly. The main reason why I initially decided to go with Apple‘s controller class was to guarantee an expected look&feel/behaviour for all iOS versions. Let‘s give it another beta or two to see if this gets fixed. It seems like that all views inside the action sheet besides the button are simply cut out 😔

@schenkty
Copy link
Author

Can you report the issue to Apple? Maybe they can fix it or suggest the best option moving forward.

@chrs1885
Copy link
Owner

Well, the documentation says that the alert controller is not ment to be customized. Maybe this is on purpose. There seems to be a guy having the same issue: https://stackoverflow.com/questions/56955800/ios13-uialertcontroller-with-custom-view-preferredstyle-as-actionsheet-graysca

@chrs1885
Copy link
Owner

Presenting the picker inside an alert instead of an action sheet might be a workaround for now.

@schenkty
Copy link
Author

If the same functionality can be done with a custom controller. that may be the best option. I wouldn't suggest doing a hot fix to just have to fix it again with another iOS change.

@chrs1885
Copy link
Owner

I‘m gonna install iOS 13 on one of my testing devices to see if the music app (which also seems to have custom action sheets) can handle the issue properly. If so, I will start to work on a custom controller that immitates the look and feel 😉

@schenkty
Copy link
Author

Sounds great! Thank you for the commitment to this repo, it’s truly awesome.

@chrs1885
Copy link
Owner

chrs1885 commented Jul 30, 2019

@schenkty Good news. I've managed to get it working on iOS 13. I'm going to publish a new version in the upcoming days.

Bildschirmfoto 2019-07-30 um 22 53 05

@schenkty
Copy link
Author

That is awesome, congratulations! Does it work the same way as before? How does it work on iPad?

@chrs1885 chrs1885 added this to the 1.0.0 milestone Jul 31, 2019
@chrs1885
Copy link
Owner

It pretty much works the same way as before. Still, the view is based on UIAlterViewController. Didn't check the behavior on an iPad, though.

@chrs1885
Copy link
Owner

chrs1885 commented Jul 31, 2019

@schenkty This has been added to the develop branch already and is going to be part of the upcoming 1.0.0 release. Feel free to star this repo in case you are happy with it =)

@chrs1885
Copy link
Owner

chrs1885 commented Aug 7, 2019

@schenkty v 1.0.0 is available. Please let me know, what you are thinking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants