Skip to content

Commit 861d4e1

Browse files
Eden Mikitaspitdicker
Eden Mikitas
authored andcommitted
Make TimeZone::timestamp_millis_opt use
NaiveDateTime::from_timestamp_millis to reduce code duplication
1 parent 3c4846a commit 861d4e1

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

src/offset/mod.rs

+3-5
Original file line numberDiff line numberDiff line change
@@ -415,12 +415,10 @@ pub trait TimeZone: Sized + Clone {
415415
/// };
416416
/// ```
417417
fn timestamp_millis_opt(&self, millis: i64) -> LocalResult<DateTime<Self>> {
418-
let (mut secs, mut millis) = (millis / 1000, millis % 1000);
419-
if millis < 0 {
420-
secs -= 1;
421-
millis += 1000;
418+
match NaiveDateTime::from_timestamp_millis(millis) {
419+
Some(dt) => LocalResult::Single(self.from_utc_datetime(&dt)),
420+
None => LocalResult::None,
422421
}
423-
self.timestamp_opt(secs, millis as u32 * 1_000_000)
424422
}
425423

426424
/// Makes a new `DateTime` from the number of non-leap nanoseconds

0 commit comments

Comments
 (0)