-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to turn off color correction #1672
Comments
yes please, I just wanted to add that looking at issue #341 might help: the code that color corrects bgb output:
this makes the rom look like on "original screen" and is reverse engineered in GB Studio, to make colors in the editor look like the later output in bgb. Problem: in reality the colors on the rom are way more saturated -> playing on any other emulator than bgb, or on original hardware with ips screens will show colors that are way off. either make the implemented bgb emulator without this color correction or provide an option to turn it off in the editor. thank you! |
@chrismaltby I would also love it if this got some attention. It’s now super hard to see how your game will look on a FPGA/modded LCD screen (or even original hardware). Even though I know each screen will display colors differently, I find myself going back to my palettes constantly to adjust for oversaturated colors. The BGB corrections are just too far off. |
Having an unfiltered color option would be amazing! I mentioned here that binjgb can be configured to have uncorrected colors, however it’d most likely require recompiling GB Studio. Although I’m sure how to turn off the color-correction within GB Studio’s interface, you can see more about configuring binjgb here: |
I also think this would be a huge improvement. It's really hard to get colors right because of the uncommon color correction. I use Sameboy because it's the most accurate Gameboy emulator and there's no way to get it to look similar to BGB's correction |
Cool, I agree this would be useful. I've just started working on a branch that adds a setting to disable the inbuilt color correction (both in the IDE preview and the the emulator) Once builds are finished (assuming no issues) you should be able to try this version here: There might be a few edge case issues to pick up but once I'm happy with this will merge and the feature should be included in the next release :-) |
The default color palette handler presumes we’re using the BGB emulator and compensates for the colors chosen, which may not be a true-to-all-cases solution.
This results in oversaturated colors on some devices that do not use that method of color correction, and it looks jarring.
It would be nice to be able to toggle it on or off, so as to adapt to different options (IPS screen GBC or even emulators), depending on each use case.
The text was updated successfully, but these errors were encountered: