Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary log when trading multiple symbols with multiple grid trade rows #458

Closed
uhliksk opened this issue Aug 7, 2022 · 1 comment
Closed
Labels
enhancement New feature or request

Comments

@uhliksk
Copy link
Contributor

uhliksk commented Aug 7, 2022

Is your proposal related to a problem?

My SSD is wearing pretty fast because of massive log generated by binance-bot docker container. For the last 24 hours more than 650 GB of log has been rotated which extrapolated is about 235 TB per year. The most data is created by Start step and Finish step events even by symbols not actually traded because of max. open trades limit. Those data are repetitive without the changes significant to track.

Describe the solution you'd like

The Start step operation should not save the full data into log and it should just store actual state into temporary variable. Then when Finish step is reached the temporary variable should be compared with the actual data and only a modified values should be written into log. This way a significant portion of the log will be cut off. Full data should be saved just at the start of cycle or even less frequently.

Describe alternatives you've considered

I had to disable logging at all in my production environment which is very bad decision as the ability to track any issues is very limited without the log.

Additional context

Massive log may be responsible for missed sell orders described in #451 as it can cause undesirable delayed writes to database or even unexpected hardware or driver failures.

@uhliksk
Copy link
Contributor Author

uhliksk commented Jan 11, 2023

Delayed writes indirectly solved in #562 as events are processed sequentially and thus timing doesn't matter anymore. As intensive logging is solved by logging errors only I don't need this to be fixed anymore.

@uhliksk uhliksk closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant