Profit/Loss percentage calculated incorrectly

[Bajt1]

Version

0.0.75

Description

Profit/Loss is showning correct values in absolute numbers, but incorrect for percentage. I believe (I wasn't able to find this calculation in the code) this is due to the fact that the percentage base is calculated from the current estimated value.
If we have a profit, the bigger profit we have, the bigger is the base => percentage shown is smaller than it should be
If we have a loss, the bigger loss we have, the smaller is the base => negative percentage shown is bigger than it should be

Screenshots

Profit/Loss is showing 12.51% profit, but in reality, the profit is 14.30%.
Calculating the Profit/Loss percentage from current and last buy price should give the correct values ((current / lastBuy -1)*100)

[habibalkhabbaz]

It makes sense!
I see that the profit percentage is calculated like below:
(1 - lastBuyPrice / currentPrice) * 100

I don't know if there is a reason behind this. Maybe @chrisleekr can explain this.

[chrisleekr]

@Bajt1

Oh yeah, you are right. I have to calculate (Current price/Last Buy Price - 1)*100

I will fix up later.

	Price	Qty	Total
Current price	3.749	91.459	342.879791
Last buy price	3.28	91.459	299.98552
Profit			42.894271
“(D1/D2-1)*100”			14.2987804878049
“(D3/D2)*100”			14.2987804878049

[chrisleekr]

Fixed. Not released yet. I will release later with other changes.

[Bajt1]

Cool, that was quick!