Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sell strategy? #168

Closed
dts opened this issue May 11, 2021 · 7 comments
Closed

Sell strategy? #168

dts opened this issue May 11, 2021 · 7 comments
Labels
question Further information is requested

Comments

@dts
Copy link

dts commented May 11, 2021

It appears that the default strategy is basically "sell everything when it's at a 7-day high" - is this read accurate? If so - are there plans to change that to be a little less aggressive? Perhaps keeping track of the last sell price, and selling some fraction of holdings as it ratchets up?

@dts dts added the question Further information is requested label May 11, 2021
@ottuzzi
Copy link

ottuzzi commented May 12, 2021

Hi,

sell strategy is not what you have described: you set a trigger (say +3.5%) and when the price is above the buyPrice+trigger the bot will place a STOP-LOSS-LIMIT sell order. The trigger is in your hand and you can choose the value.

@andferno
Copy link

It appears that the default strategy is basically "sell everything when it's at a 7-day high" - is this read accurate? If so - are there plans to change that to be a little less aggressive? Perhaps keeping track of the last sell price, and selling some fraction of holdings as it ratchets up?

#158 is what you are requesting.

@chrisleekr
Copy link
Owner

Thanks for your input, @ottuzzi @andferno

@dts I am not sure where you get "sell everything when it's at a 7-day high"

I suggest reading README.md how it works.

@dts
Copy link
Author

dts commented May 13, 2021

I read through the readme, started running it, and it wasn't until I read the code until I noticed this. In place-sell-order.js:

const orderQuantity = parseFloat(
    _.floor(freeBalance - freeBalance * (0.1 / 100), lotPrecision)
  );

And that value isn't checked against any other thing - i.e. the order quantity is the free balance less 0.001%. In place-buy-order, it is compared against the maxPurchaseAmount, however.

@andferno
Copy link

Selling orders doesn't have a limit as you can check into settings. It's only for buying. So when selling it sells all because doesn't have any setting to compare to.
That's why I told you that #158 will help you. Because you'll be able to set limits to grids. If you select only one grid you'll be able to select that limit also.

@chrisleekr
Copy link
Owner

@dts

@andferno is correct. Sell action will sell all your coins.

@chrisleekr
Copy link
Owner

@dts
Please close the issue if your question is answered.

@dts dts closed this as completed May 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants