node compatibility problem ?

[vincen57]

Hello,

I discovered your node a few days ago. Unfortunately I can't use it because I can't display the control panel.

I suppose there's an incompatibility with one of the many nodes I've already installed (>500). Hard to know which one...

Too bad, because your idea is really brilliant.

[JorgeR81]

500 nodes !

Well, ... I have these. They should be fine.

• ComfyUI_Noise
• cg-use-everywhere
• ComfyUI_ADV_CLIP_emb
• ComfyUI_TiledKSampler
• ComfyUI_Cutoff
• ComfyUI-AutomaticCFG
• ComfyUI_InstantID
• ComfyUI_IPAdapter_plus
• ComfyUI-Custom-Scripts
• ComfyUI_UltimateSDUpscale
• ComfyUI-GGUF
• rgthree-comfy
• ComfyUI-KJNodes
• ComfyUI-0246
• aegisflow_utility_nodes
• ComfyUI_essentials
• comfyui_controlnet_aux
• ComfyUI-Inspire-Pack
• ComfyUI_smZNodes
• ComfyUI-Marigold
• ComfyUI-Manager
• PuLID_ComfyUI
• ComfyUI_FaceAnalysis
• ComfyUI-Impact-Pack
• comfyui-reactor-node
• was-node-suite-comfyui

[vincen57]

Here's the list of my intalled nodes. There aren't actually 500... But some libraries contain several hundred. We need to know what we mean by the word ‘node’...

0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\cg-controller
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Better-Strings
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\loadImageWithSubfolders.py
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\websocket_image_save.py
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-mape-Helpers
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-openpose-editor
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\comfyui-loadimagewithsubfolder
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_ResolutionSelector
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Noise
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Inpaint-CropAndStitch
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\comfyui-prompt-composer
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\SDXL_sizing
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Cutoff
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Logic
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\cg-use-everywhere
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\comfyui-portrait-master
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Custom-Scripts
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Prompt-MZ
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\comfyui-browser
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_UltimateSDUpscale
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\save-image-extended-comfyui
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-N-Sidebar
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\rgthree-comfy
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_IPAdapter_plus
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\comfyui-workspace-manager
0.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\comfyui_controlnet_aux
0.1 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Crystools
0.4 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Manager
0.5 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI_Comfyroll_CustomNodes
0.7 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Easy-Use
1.0 seconds: C:\ComfyUI\ComfyUI\custom_nodes\comfyui-reactor-node
1.3 seconds: C:\ComfyUI\ComfyUI\custom_nodes\ComfyUI-Inspyrenet-Rembg
1.5 seconds: C:\ComfyUI\ComfyUI\custom_nodes\was-node-suite-comfyui

[JorgeR81]

First, let's wait to see if @chrisgoringe, can figure out the problem.

But, what I do in these cases, is to disable the nodes, one by one, in the Manager, and see if that fixes the issue.

You don't need to uninstall the nodes ! Just disable them.

After enabling / disabling you need to restart ComfyUI, for the changes to be applied.
You can also disable and enable multiple nodes at a time.
You could even start by disabling all, except the Controller ( and other nodes that I have ), to see if the issue is really caused by another custom node.

The nodes in my list should be fine.
I could start with nodes that also make changes to the GUI,
( e.g. ComfyUI-N-Sidebar, ComfyUI-Easy-Use, ComfyUI-Crystools, comfyui-workspace-manager ).

Once you find the conflicting node, the other developer can also help fix this.

[JorgeR81]

If it's a conflicting node, it should be one of these.
I don't have none of them.

• ComfyUI-Better-Strings
• ComfyUI-mape-Helpers
• ComfyUI-openpose-editor
• comfyui-loadimagewithsubfolder
• ComfyUI_ResolutionSelector
• ComfyUI-Inpaint-CropAndStitch
• comfyui-prompt-composer
• SDXL_sizing
• ComfyUI-Logic
• comfyui-portrait-master
• ComfyUI-Prompt-MZ
• comfyui-browser
• save-image-extended-comfyui
• ComfyUI-N-Sidebar
• comfyui-workspace-manager
• ComfyUI-Crystools
• ComfyUI_Comfyroll_CustomNodes
• ComfyUI-Easy-Use
• ComfyUI-Inspyrenet-Rembg

[chrisgoringe]

Could you press f11 on the browser and see if there are any errors in the JavaScript console?

[vincen57]

Ok, in Firefox with the F12 key, I get the following error message:

Uncaught TypeError: (intermediate value).graph.nodes is undefined
build_controllerPanel http://192.168.1.130:7865/extensions/cg-controller/controller_panel.js:203
show http://192.168.1.130:7865/extensions/cg-controller/controller_panel.js:54
toggle http://192.168.1.130:7865/extensions/cg-controller/controller_panel.js:44
callback http://192.168.1.130:7865/extensions/cg-controller/controller_controls.js:13
methodname http://192.168.1.130:7865/extensions/cg-use-everywhere/use_everywhere_utilities.js:259
l http://192.168.1.130:7865/extensions/ComfyUI-Easy-Use/assets/extensions-B7ZXlNKx.js:1

[vincen57]

Please note that your node was installed with ComfyUI Manager Menu and not with git.

[JorgeR81]

Yeah, I also used the Manager. That's probably not it.

[chrisgoringe]

Thanks for the bug report... looks like there is a timing issue with the controller being constructed before the graph is ready. Possibly because of the number of custom nodes all needing to start up!

I've just push a very small change - if you could update the node and try? You'll probably need to update manually:

cd [comfy]/custom_nodes/cg-controller
git pull

and then reload the page (no need to restart comfy) and post here how it goes!

[JorgeR81]

Not sure if that would make a difference but : 

• I don't have that SDXL_sizing node
• I launch ComfyUI mostly with the default run_nvidia_gpu.bat file:

.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build
pause

[vincen57]

In my opinion, the SDXL_sizing node does not interfere with the ComfyUI UI.

I've tried running ComfyUI with run_nvidia_gpu.bat in localhost and the problem remains.

I think there's a problem with javascript. Have you tested with the Firefox browser?

[JorgeR81]

No, I used Google Chrome.

[chrisgoringe]

confirmed - a problem with firefox.

[chrisgoringe]

Pushed what I think is a fix (at least it works in FF for me now!)

[chrisgoringe]

I've also added this as an issue in the tracker (#68)