Rounding, precision, step, and sliders

[chrisgoringe]

A place to bring any discussion on these things together.

Comfy distinguishes between three concepts:

• precision (an integer) is the number of decimal places that should be displayed
• rounding (a float) - the value is rounded to a multiple of this value. Often, but not always, 0.1^(precision).
• step (a float) is the step size when doing various operations

Two problems with this design:

• if precision is 1 but rounding is 0.01, different values are permitted, appear the same, but are different (0.38 and 0.42 are both allowed, and both appear as 0.4)
• if rounding > 2 * step size, a step will be 'rounded away'

So the expected slider behaviour at present is as follows:

• widget step size is ignored; rounding is used as the step size
• if the step size is smaller than 0.1^(precision), precision is increased until that is not the case
• if you change the step size, precision may be increased (but never decreased)
• special case: if rounding is 0 and step size is 1, it's an integer. Step size constrained to integer values.

[JorgeR81]

I was also expecting another behavior:

• when you type values, you can override step size.

---

Now, if I have a 0.05 step size, I can't type a value of 0.47

I know that to type and see a value of 0.473, I need a precision of 3
But it would be nice to be able to type all values, within my level of precision.

And if I change this 0.47 value gain, by a single step ( via scrolling or dragging ),
I would want this to be changed to 0.45, or 0.50 ( not 0.52 or 0.42 ).

But given how complex this system is, I don't know if this is possible.

[LukeG89]

Could it be possible in CFG values to set the default step at 0.1 instead of 0.01? I have "Float widget rounding" set to auto, and all CFGs have 1 decimal digits. But when I add the node to Controller, they will be converted to 2 decimal digits, and I can't revert the change anymore.
If users want that precision, they should do it manually.

[JorgeR81]

Yes, it would be nice if the sliders also had different levels of precision, if you set precision to "AUTO".

Ideally, the slider should use the native widget's precision, and not vice versa.

[chrisgoringe]

What behaviour would you expect if precision is 1, but step is 0.01? When you (for instance) roll the scroll wheel?

Having a precision that hides differences in values seems very wrong to me.

[chrisgoringe]

One option would be to allow precision to take precedence over step size - so if the cfg has a precision of 1, the step size would start at 0.1 instead of the widget step size of 0.01

[JorgeR81]

One option would be to allow precision to take precedence over step size - so if the cfg has a precision of 1, the step size would start at 0.1 instead of the widget step size of 0.01

I agree.

And the edit box could be red, like now, to indicate invalid inputs

[LukeG89]

Now I see that some widgets get rounded to 2 decimal digits like CFGs (even though they are all INTs)

rounding.mp4

[LukeG89]

Found a bug when changing step size more than 1 to steps: There's a +1 value difference.

One_Value_Difference.mp4

[chrisgoringe]

try now

[chrisgoringe]

to test you need min(1) or something...

[JorgeR81]

Ah right, min(1), max(10), step(4) gives 1, 5, 9, 10 in the widget, ( and 10, 6 2, 1 while decreasing )

[LukeG89]

Now the bug is fixed!

[JorgeR81]

Yes, now it works !

[JorgeR81]

Weird precision behavior:

I have precision set to auto.
I have 2 workflows with ControlNet

---

In one of the workflows precision is 3, in the percent sliders. 

---

In the other workflow other is also 3, with the Controller closed.

---

But when I open the controller, it changes to 2

---

If I close the Controller, and refresh the browser, precision is 3 again

[chrisgoringe]

Maybe you could post this as a new issue (and link the workflow). But I'm not touching this before 1.0!

[JorgeR81]

OK.

Just for reference, what's the expected behavior ? 1st or 2nd workflow ?

All my new workflows are behaving like the first one.