Skip to content
This repository has been archived by the owner on Oct 16, 2024. It is now read-only.

Library is now deprecated #100

Closed
chrisbanes opened this issue May 30, 2024 · 6 comments
Closed

Library is now deprecated #100

chrisbanes opened this issue May 30, 2024 · 6 comments

Comments

@chrisbanes
Copy link
Owner

chrisbanes commented May 30, 2024

This is a future notice that this library will soon be deprecated.

The window size class library is now included in Compose Multiplatform 1.7.0 (currently pre-release). This library will be deprecated as soon as 1.7.0 goes stable.


Update (15/10/25)

This library is now deprecated, as JetBrains have released their own version as part of Compose Multiplatform 1.7.0.

👋

@harish-zuper
Copy link

Thanks for the info :)

@frankois944
Copy link

frankois944 commented Aug 25, 2024

Hi, sizeclass has been added to compose multiplatform

https://github.com/JetBrains/compose-multiplatform/releases/tag/v1.7.0-alpha03

@chrisbanes
Copy link
Owner Author

Yep, just updated this issue’s description.

@CXwudi
Copy link

CXwudi commented Oct 15, 2024

Hi, today 1.7.0 goes GA. However, based on the release note, it lacks a commonized calculateWindowSizeClass() method, which I believe is still necessary for adaptive UI. There are two options:

  1. Adapt this library to depends on the new material3-window-size-class and simply provide a commonized calculateWindowSizeClass() method
  2. Still deprecate this library but extract the commonized calculateWindowSizeClass() implementation into a GitHub Gist for future reference, or create a new library just for commonized calculateWindowSizeClass()

I am fine with either options

@chrisbanes
Copy link
Owner Author

Thanks for the update.

I have no plans to make any further changes to this library, so will proceed with the deprecation as planned.

As to comminization, I think that this is best handled at the app level. AFAICT, the JetBrains team hasn’t added a common function yet, because they haven’t implemented the necessary hooks on certain platforms. All of the major platforms have a calculateWindowSizeClass() function though, so it's just a case of adding some trivial expect/actual functions.

@chrisbanes chrisbanes changed the title [PENDING] Library will soon be deprecated Library is now deprecated Oct 15, 2024
@Skaldebane
Copy link
Contributor

I guess it might be a good idea to archive the repository as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants