Include sys/sysmacros.h for to fix build
#5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the source on Debian sid/unstable with libc6 2.31-5 and UUID support
(default) results in the build failure below.
CC tiny_initramfs-devices.o
CC tiny_initramfs-util.o
devices.c: In function 'scan_devices':
devices.c:290:15: warning: implicit declaration of function 'major' [-Wimplicit-function-declaration]
290 | if (major(st.st_rdev) == maj && minor(st.st_rdev) == min) {
| ^~~~~
devices.c:290:33: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
290 | if (major(st.st_rdev) == maj && minor(st.st_rdev) == min) {
| ^~
devices.c:290:43: warning: implicit declaration of function 'minor' [-Wimplicit-function-declaration]
290 | if (major(st.st_rdev) == maj && minor(st.st_rdev) == min) {
| ^~~~~
devices.c:290:61: warning: comparison of integer expressions of different signedness: 'int' and 'unsigned int' [-Wsign-compare]
290 | if (major(st.st_rdev) == maj && minor(st.st_rdev) == min) {
| ^~
CCLD tiny_initramfs
/usr/bin/ld: tiny_initramfs-devices.o: in function `scan_devices':
devices.c:(.text+0x520): undefined reference to `major'
/usr/bin/ld: devices.c:(.text+0x539): undefined reference to `minor'
collect2: error: ld returned 1 exit status
make[1]: *** [Makefile:398: tiny_initramfs] Error 1
Explicitly include the header `sys/sysmacros.h`, where `major()` and `minor()`
are defined.
Resolves: chris-se#4
paulmenzel
force-pushed
the
include-sysmacros.h-to-fix-build
branch
from
2395f5b to
f504663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Debian sid/unstable.