Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark #91

Open
yoshuawuyts opened this issue Nov 1, 2017 · 4 comments
Open

benchmark #91

yoshuawuyts opened this issue Nov 1, 2017 · 4 comments

Comments

@yoshuawuyts
Copy link
Member

It'd be neat to have a benchmark to test our diffing needs — perf is a feature, and we should be able to catch regressions.

Given this would need to run in the browser, we'd probably need some tooling around this. I was thinking it'd be cool to run a headless Chrome instance through puppeteer, and use the nanobench module to perform the benches. Would be neat if we could run it as a standalone CLI thing, with similar output to TAP.

But by all means — feel free to pick up this issue, and run with it. Probably worth picking up similar benches as in choojs/choo#492.

Hope this makes sense. Thanks!

@tkh44
Copy link

tkh44 commented Nov 1, 2017

FWIW we have some benchmarks setup for emotion that use puppeteer and run on every ci build. Might be some useful stuff to steal. https://github.com/emotion-js/emotion/tree/master/packages/benchmarks

@him2him2
Copy link
Collaborator

him2him2 commented Nov 1, 2017

This looks interesting. I would be happy to take it on.

@graforlock
Copy link
Member

graforlock commented Nov 1, 2017

It'd be cool as I believe there was some regression of choo 5 vs 6, and it chould've been caught

We can do a CI docker build to run it automatically on npm release bumps, this would be best solution

@yoshuawuyts
Copy link
Member Author

@him2him2 amazing! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants