Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

Erroneous detection of "installArguments" #181

Open
bc3tech opened this issue Jun 28, 2018 · 1 comment
Open

Erroneous detection of "installArguments" #181

bc3tech opened this issue Jun 28, 2018 · 1 comment

Comments

@bc3tech
Copy link

bc3tech commented Jun 28, 2018

This line causes erroneous detection and failure of packages that use any variable name that contains installArguments as a substring.

Real-world effect can be seen here where the uninstall script uses a registry key called UninstallArguments and is being caught & falsely failed by this validation check.

seems like a better check would be .Contains("$installArguments"), etc

@bc3tech
Copy link
Author

bc3tech commented Jul 7, 2018

Now impacting a stable push here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant