Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Higher limit for package size #59

Closed
majkinetor opened this issue Jun 4, 2021 · 5 comments
Closed

Higher limit for package size #59

majkinetor opened this issue Jun 4, 2021 · 5 comments

Comments

@majkinetor
Copy link

I think 200MB limit is too small in current day and age. It was introduced years ago and there was that gallery bug also with larger packages.

So

  1. Years passed, so size should go up because in Electron age, todo apps can have 100MB+
  2. Packages with multiple arch are particularly problematic as limit is shared among them.
  3. Workaround for single arch fitting in is workable although not nice, for multi-arch is highly problematic because it boils down to multiple packages or non-embedded packages (which are next to junk for me at least and I don't use them except for few tools like browsers)
  4. The gallery bug is fixed

I think around 500MB would be good next limit, but even smaller changes would be beneficial, but not bellow 350MB IMO. Ideally 1 GB value would be nice for foreseeable future.

Originally posted by @majkinetor in #48 (comment)

@TheCakeIsNaOH
Copy link
Member

I absolutely agree.
Embedded packages are vastly better when it is possible to embed the binaries.

There are a list of packages which I use that would be embeddable if the file size limit was larger.

@chitrarthSahai
Copy link

Hi,

Is there any package size limit to host packages in our internal feed as well?? What if the application I want to deploy is over a GB?

@TheCakeIsNaOH
Copy link
Member

@chitrarthSahai There is not a limit built into choco.exe that I am aware of.

Currently, choco cannot hash the .nupkg on install if it is over 2gb in size, but that issue produces a warning, not an error. See chocolatey/choco#747 for more information and to track the issue.

There is likely a limit built into your internal feed. but that depends on what software you are using to host your feed and how it is configured. For example, most reverse proxies have a configuration option to limit the max upload and download sizes, which would put a limit on the size of a package. Or a limit may be built into the software providing your feed.

In terms of what is practical however, I would generally suggest limiting your package sizes to about 1.5gb. Anything larger, and it can start to get a bit unreliable in my experience during the download of the package, and extracting the package take longer, and it can start to use up significant disk space.

To get around this, I would suggest downloading large installers and other binaries from other internal sources. SMB share, S3, Wasabi, other private HTTP server, etc. Anything that would make the package over 1.5-2gb

@bdukes
Copy link

bdukes commented Nov 15, 2021

I've just run into this with the imagemagick.tool package (see Discord discussion)

@pauby
Copy link
Member

pauby commented Feb 25, 2022

While I know this question has come up a few times, it's not quite as simple to resolve as it may seem. This is something that the Chocolatey Team have regularly spoken about, but it's not something that has been possible to progress. But it is something we know is needed, and it is not something we have forgotten about.

Having said that, to manage expectations, this is unlikely to be resolved in the near future.

@chocolatey chocolatey locked and limited conversation to collaborators Jun 4, 2022
@pauby pauby converted this issue into discussion #163 Jun 4, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants