This repository has been archived by the owner on Feb 19, 2019. It is now read-only.
Fix bash arg quoting, remove bash/batch shortcuts on uninstall #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a Chocolatey-Uninstall is done, the bash and batch shortcuts will now be removed using Remove-BinFile I've also added a message in Generate-BinFile that the bash shortcut is getting added, as this was missing. I've also added a message to Chocolatey-Uninstall describing which directory is removed on uninstall.
| @@ -11,6 +11,7 @@ param( | |||
| $path = $path.ToLower().Replace($nugetPath.ToLower(), "%DIR%..\").Replace("\\","\") | |||
| $pathBash = $path.Replace("%DIR%..\","`$DIR/../").Replace("\","/") | |||
| Write-Host "Adding $packageBatchFileName and pointing to `'$path`'." -ForegroundColor $Note | |||
| Write-Host "Adding $packageBashFileName and pointing to `'$path`'." -ForegroundColor $Note | |||
There was a problem hiding this comment.
I added this line, because the existing code seemed inconsistent (it displays a message about the batch file, but not about the bash file)
When the args contain spaces, the existing shell script would fail. If we quote the args this will fix the problem
ghost
assigned 
|
This is in. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put quotes around the args passed to the bash shell script (without quotes spaces in the args will not work)
When a Chocolatey-Uninstall is done, the bash and batch shortcuts will now be removed using Remove-BinFile
I've also added a message in Generate-BinFile that the bash shortcut is getting added, as this was missing.
I've also added a message to Chocolatey-Uninstall describing which directory is removed on uninstall.