(#3465) Allow building an MSI during outside of tagged commits. #3466
Conversation
Prepare-Chocolatey-Package previously would fail if not run as part of a target that also included copying the nuspec files. This commit makes the task dependency explicit so you can directly run Prepare-Chocolatey-Package.
Changed the logic for skipping an MSI build to skip it by default, and no longer depend on a tagged build. This will allow developers to generate an MSI by adding `--shouldBuildMsi=true`.
When running the builds in CI, we should generate the MSI as well. This will allow us to get an MSI for any build to test with if needed.
As with the previous commit, this adds the configuration for GitHub Actions. Thus allowing us to ensure the MSI is able to be built in GitHub Actions as well. When running the builds in CI, we should generate the MSI as well. This will allow us to get an MSI for any build to test with if needed.
|
Note: The MSI task in the GHA ran successfully, but Chocolatey.Cake.Recipe doesn't currently try to upload the MSI on GHA: https://github.com/chocolatey/Chocolatey.Cake.Recipe/blob/e4ac5d739a594f24d62c8502dfa4573da59f5267/Chocolatey.Cake.Recipe/Content/build.cake#L482 |
There was a problem hiding this comment.
The line endings on this was not intentionally changed. I suspect it was the editorconfig that caused it here.
There was a problem hiding this comment.
If that were the case, then why wouldn't this have changed before? What extension are you using in VSCode for EditorConfig?
There was a problem hiding this comment.
I am not against there being changes to line-endings, if they are indeed intended based on our .editorconfig settings, but this change would need to be done in a separate commit.
There was a problem hiding this comment.
The extension I have installed in VSCode is:
Name: EditorConfig for VS Code
Id: EditorConfig.EditorConfig
Description: EditorConfig Support for Visual Studio Code
Version: 0.16.4
Publisher: EditorConfig
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=EditorConfig.EditorConfig
It is affected by the setting of CRLF for all files in .editorconfig. I'll get a commit sorted out to convert the file to CRLF and get that pushed up.
Description Of Changes
Update the Recipe used to default to not build an MSI. Update the CI configurations to allow building the MSI with the addition of the
--shouldBuildMsi=trueparameter.Motivation and Context
Ease the experience of making adjustments to the MSI. Allow us to get an MSI more regularly for testing.
Testing
./build.bat --target=Build-Msi./build.bat --target=Build-Msi --shouldBuildMsi=truecode_drop/Artifactsandcode_drop/MSIs/en-USdirectories to confirm that an MSI was generated.Operating Systems Testing
Change Types Made
Change Checklist
Related Issue
Fixes #3465