(GH-513) Add keybinding for navigating sources #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@huffSamuel just wanted to say that I am not ignoring this PR, just been busy getting a few other things lined up, before I will be able to look at this properly. Thanks for doing this! |
| </KeyBinding.CommandParameter> | ||
| </KeyBinding> | ||
|
|
||
| </Window.InputBindings> |
There was a problem hiding this comment.
Why 9 options to get to sources?
There was a problem hiding this comment.
The intent was to support quick jumping to the first 9 sources in the list. I limited to 9 as that is a convenient number to stop at due to keyboard layout. Extending beyond that seemed somewhat excessive for quick access with a single key combination.
Fix 513 by adding keyboard bindings ctrl+1..9 to switch between respective source indexes.
This isn't available in older version of the .Net Runtime, which Chocolatey GUI is still targeting.
|
@huffSamuel your changes have been merged, thanks for your contribution 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix 513 by adding keyboard bindings ctrl+1..9 to switch between respective source indexes.
Closes #513