Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkbox replaced with tick/cross chars #191

Merged
merged 2 commits into from
Dec 19, 2014
Merged

Checkbox replaced with tick/cross chars #191

merged 2 commits into from
Dec 19, 2014

Conversation

ulex
Copy link
Contributor

@ulex ulex commented Dec 19, 2014

Hi. For new users checkbox column is very frustrating (I'm personally clicked it)
I'm suggest to replace this checkbox column with simple text with '✓' or '✗'

ps
also, I'm fix a little typo.

@RichiCoder1
Copy link
Contributor

I'd personally like to avoid '✗' if it isn't installed, but I otherwise like it. My reasoning is that I'd like the behavior that nuget 3.0 (and other PMs) have, where a combined installed/available tab defaults to blank if not installed, checked if installed, and up arrow (or something similiar) if an update is available. Update, at least, would be beyond this scope of this change, for now.

ps
Thanks :D

@ulex
Copy link
Contributor Author

ulex commented Dec 19, 2014

Yeah, I'm agree. Without cross it's really easy to determine installed packages from others.
Support for update mark looks like a small feature, not a fix like this 😄

@RichiCoder1 RichiCoder1 self-assigned this Dec 19, 2014
@RichiCoder1 RichiCoder1 added Bug Issues where something has happened which was not expected or intended Tests Issues related to the tests (NUnit, xUnit, Pester, Etc) Improvement Issues that enhances existing functionality, or adds new features and removed Bug Issues where something has happened which was not expected or intended Tests Issues related to the tests (NUnit, xUnit, Pester, Etc) labels Dec 19, 2014
@RichiCoder1
Copy link
Contributor

Looks good to me.

RichiCoder1 added a commit that referenced this pull request Dec 19, 2014
Installed now displays a check if package is installed.
@RichiCoder1 RichiCoder1 merged commit 29fa610 into chocolatey:develop Dec 19, 2014
@gep13 gep13 added this to the 0.12 milestone Dec 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants