Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to target version 2.0.0 of Chocolatey.Lib assemblies #974

Closed
2 tasks done
TheCakeIsNaOH opened this issue Jan 6, 2023 · 5 comments
Closed
2 tasks done

Upgrade to target version 2.0.0 of Chocolatey.Lib assemblies #974

TheCakeIsNaOH opened this issue Jan 6, 2023 · 5 comments
Labels
5 - Released The issue has been resolved, and released to the public for consumption BreakingChange The issue will introduce backwards incompatible changes
Milestone
2.0.0

Comments

@TheCakeIsNaOH
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

As Chocolatey CLI will be moving to v2.0.0 at some point, Chocolatey GUI should take a dependency on it.

Describe The Solution. Why is it needed?

The chocolatey.lib dependency needs to be updated, and code needs to be adjusted to account for breaking changes.

Additional Context

No response

Related Issues
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 6, 2023
@TheCakeIsNaOH
(chocolatey#974) Switch to NuGetVersion from NuGet.Client
9083ff8
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 6, 2023
@TheCakeIsNaOH
(chocolatey#974) Add required extension method
d6a9902 
The RemoveAll method is not longer accessible from NuGet.Client, so
add it here manually
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 6, 2023
@TheCakeIsNaOH
(chocolatey#974) Adjust to breaking changes.
7d94919
@TheCakeIsNaOH TheCakeIsNaOH mentioned this issue Jan 6, 2023
Merged
10 tasks
@gep13 gep13 added this to the 2.0.0 milestone Jan 6, 2023
@gep13
Copy link
Member

gep13 commented Jan 6, 2023

@TheCakeIsNaOH @AdmiringWorm I have added this issue to a new 2.0.0 milestone, but I am now wondering if this needs to be a 2.0.0 and not just a 1.2.0. Thoughts? My thoughts here being that Chocolatey GUI already has a requirement for .NET Framework 4.8.

@gep13
Copy link
Member

gep13 commented Jan 6, 2023

Just spoken with @TheCakeIsNaOH about this, and we agree that this will be a breaking change to Chocolatey GUI, so the next version will be 2.0.0

@AdmiringWorm
Copy link
Member

If we start taking a minimum dependency on Chocolatey v2.0.0, I agree this will be a breaking change.

TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 6, 2023
@TheCakeIsNaOH
(chocolatey#974) Switch to NuGetVersion from NuGet.Client
e26a32c
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 6, 2023
@TheCakeIsNaOH
(chocolatey#974) Add required extension method
c7d162a 
The RemoveAll method is not longer accessible from NuGet.Client, so
add it here manually
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 6, 2023
@TheCakeIsNaOH
(chocolatey#974) Adjust to breaking changes.
50f0c7a
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 6, 2023
@TheCakeIsNaOH
(chocolatey#974) Switch to NuGetVersion from NuGet.Client
9634bef
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 6, 2023
@TheCakeIsNaOH
(chocolatey#974) Add required extension method
33f2a8b 
The RemoveAll method is not longer accessible from NuGet.Client, so
add it here manually
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 6, 2023
@TheCakeIsNaOH
(chocolatey#974) Adjust to breaking changes.
0013b92
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 10, 2023
@TheCakeIsNaOH
(chocolatey#974) Fix bindings IsLatestVersion -> IsOutdated
6b36a16
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 11, 2023
@TheCakeIsNaOH
(chocolatey#974) Fix bindings IsLatestVersion -> IsOutdated
b0473cb
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 11, 2023
@TheCakeIsNaOH
(chocolatey#974) Switch to NuGetVersion from NuGet.Client
2a2fdcd
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 11, 2023
@TheCakeIsNaOH
(chocolatey#974) Add required extension method
9a4ebda 
The RemoveAll method is not longer accessible from NuGet.Client, so
add it here manually
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 11, 2023
@TheCakeIsNaOH
(chocolatey#974) Adjust to breaking changes.
2b10e51
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 11, 2023
@TheCakeIsNaOH
(chocolatey#974) Fix bindings IsLatestVersion -> IsOutdated
976d6d3
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 13, 2023
@TheCakeIsNaOH
(chocolatey#974) Switch to NuGetVersion from NuGet.Client
e9bf85c
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 13, 2023
@TheCakeIsNaOH
(chocolatey#974) Adjust to breaking changes.
5c24e7e
TheCakeIsNaOH added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 13, 2023
@TheCakeIsNaOH
(chocolatey#974) Fix bindings IsLatestVersion -> IsOutdated
4bb6423
AdmiringWorm added a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 16, 2023
@AdmiringWorm
(chocolatey#974) Update chocolatey.lib to latest internal version
5a45c33 
This commit updates the Chocolatey Libraries to be the latest version
we have available internally.
This will cause any open source builds to fail.
AdmiringWorm pushed a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 16, 2023
@TheCakeIsNaOH @AdmiringWorm
(chocolatey#974) Switch to NuGetVersion from NuGet.Client
eaa2750
AdmiringWorm pushed a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 16, 2023
@TheCakeIsNaOH @AdmiringWorm
(chocolatey#974) Adjust to breaking changes.
191ad37
AdmiringWorm pushed a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 16, 2023
@TheCakeIsNaOH @AdmiringWorm
(chocolatey#974) Fix bindings IsLatestVersion -> IsOutdated
2eb3cc9
gep13 pushed a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 25, 2023
@AdmiringWorm @gep13
(chocolatey#974) Update chocolatey.lib to latest version
86f974c 
This commit updates the Chocolatey Libraries to be the latest version
available on NuGet.org.
gep13 pushed a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 25, 2023
@TheCakeIsNaOH @gep13
(chocolatey#974) Switch to NuGetVersion from NuGet.Client
2bd7790
gep13 pushed a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 25, 2023
@TheCakeIsNaOH @gep13
(chocolatey#974) Adjust to breaking changes.
b8b2c3a
gep13 pushed a commit to TheCakeIsNaOH/ChocolateyGUI that referenced this issue Jan 25, 2023
@TheCakeIsNaOH @gep13
(chocolatey#974) Fix bindings IsLatestVersion -> IsOutdated
5f36d77
gep13 added a commit that referenced this issue Jan 25, 2023
@gep13
Merge pull request #975 from TheCakeIsNaOH/nuget-uplift
9aebe38 
(#974) Preliminary update chocolatey.lib
@gep13 gep13 added BreakingChange The issue will introduce backwards incompatible changes REQUIRES DEPENDENCY UPDATE labels Jan 25, 2023
@gep13
Copy link
Member

gep13 commented Jan 25, 2023

While the PR associated with this has been merged, we still need to bump the version number in the nuspec, but we can't do that quite yet, unless we take a dependency on the alpha release, in the interim, or we simply hold off and update it to 2.0.0 once we ship.

gep13 added a commit that referenced this issue Jan 27, 2023
@gep13
(#974) Modify references to Chocolatey assembly
711822a 
In order for things to work correctly, both during debugging, and
release builds, it is necessary to remove the explicit targetting of
the referenced Chocolatey assembly.  This is similar to what is done
elsewhere in other Chocolatey codebases, and allows for both officially
signed, and non-officially signed, refernces to be used.
gep13 added a commit that referenced this issue Feb 4, 2023
@gep13
(#974) Update to latest version of Chocolatey.Lib
155014f 
Note: This will fail OSS builds of Chocolatey GUI until we release a
new alpha version of Chocolatey.Lib.
@gep13 gep13 changed the title Update Chocolatey CLI dependency for package to v2.0.0 Upgrade to target version 6.4.0 of NuGet.Client and version 2.0.0 of Chocolatey.Lib assemblies Feb 6, 2023
gep13 added a commit that referenced this issue Feb 17, 2023
@gep13
(#974) Update to latest version of Chocolatey.Lib
d0a138e
gep13 added a commit that referenced this issue Feb 20, 2023
@gep13
(#974) Update to latest version of Chocolatey.Lib
2827e9b
gep13 added a commit that referenced this issue Feb 21, 2023
@gep13
(#974) Update to alpha release of Chocolatey.Lib
e95daed 
This includes bumping the dependency in the nuspec to the required
version range.
gep13 added a commit that referenced this issue Mar 6, 2023
@gep13
(#974) Ensure Chocolatey assemblies not in MSI
76d1800 
Ensure that the chocolatey.dll and chocolatey.pdb file are not copied
into the MSI file. ChocolateyGUI should use only the system installed
version of Chocolatey, and not a local version.
gep13 added a commit that referenced this issue Mar 6, 2023
@gep13
(#974) Add required properties to csproj files
4128791 
In a previous commit:

86f974c

The SpecificVersion and Private properties had been removed, which
meants that the chocolatey.dll was being copied, incorrectly, to the
output folder, as well as requiring a specificversion of a referenced
assembly to be provided.

The former has been "fixed" by ensuring that the MSI project doesn't
include the chocolatey.dll into the MSI, however, this commit addresses
the issue at the source as well.  This means that while in Debug mode,
the chocolatey.dll will be copied to the output folder to help with
debugging of Chocolatey GUI, however, in other build configurations, it
will not be copied.
gep13 added a commit that referenced this issue Mar 7, 2023
@gep13
(#974) Update to alpha release of Chocolatey.Lib
3bd9035
gep13 added a commit that referenced this issue Mar 7, 2023
@gep13
(#974) Update to alpha package in nuspec
b8bd1be 
So that everything in this next release cycle lines up.
gep13 added a commit that referenced this issue Mar 17, 2023
@gep13
(#974) Update to latest alpha package
1ae765b
gep13 added a commit to gep13/ChocolateyGUI that referenced this issue Mar 20, 2023
@gep13
(chocolatey#974) Update to beta packages for Chocolatey
ea45903
gep13 added a commit that referenced this issue Mar 21, 2023
@gep13
(#974) Update to released beta packages
199c78d
@gep13 gep13 added the 4 - Done Code has been added to the repository, and has been reviewed by a team member label Mar 30, 2023
@gep13 gep13 closed this as completed Mar 30, 2023
@corbob corbob changed the title Upgrade to target version 6.4.0 of NuGet.Client and version 2.0.0 of Chocolatey.Lib assemblies Upgrade to target version 3.1.0 of Chocolatey.NuGet.Client and version 2.0.0 of Chocolatey.Lib assemblies May 19, 2023
corbob added a commit that referenced this issue May 19, 2023
@corbob
Merge branch 'release/2.0.0'
c9a531f 
* release/2.0.0: (61 commits)
  (maint) Update to latest Chocolatey NuGet package
  (maint) Update to latest Chocolatey package
  (build) Re-enable release notes export
  (maint) Added copyright to nuspec file
  (build) Updated GRM config file
  (maint) Update to released beta packages
  (maint) Switch from int to long
  (maint) Update to latest beta Chocolatey packages
  (maint) Remove @everyone from Discord notification
  (maint) Bump to beta package in nuspec
  (maint) Update to latest beta Chocolatey packages
  (build) Update to latest Chocolatey.Cake.Recipe
  (build) Remove unnecessary configuration
  (build) Add notification templates
  (maint) Prevent download of relase notes
  (#974) Update to released beta packages
  (#974) Update to beta packages for Chocolatey
  (#989) Remove usage of side by side
  (#990) Fix usage of ListCommand
  (#974) Update to latest alpha package
  ...
@corbob corbob changed the title Upgrade to target version 3.1.0 of Chocolatey.NuGet.Client and version 2.0.0 of Chocolatey.Lib assemblies Upgrade to target version 2.0.0 of Chocolatey.Lib assemblies May 19, 2023
@gep13 gep13 added 5 - Released The issue has been resolved, and released to the public for consumption and removed 4 - Done Code has been added to the repository, and has been reviewed by a team member labels May 31, 2023
@choco-bot
Copy link

🎉 This issue has been resolved in version 2.0.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

gep13 added a commit that referenced this issue May 31, 2023
@gep13
Merge branch 'master' into develop
36d8873 
* master:
  (maint) Remove usage of obsolete methods
  (#1000) Ensure sensitive arguments are detected
  (maint) Update to latest Chocolatey NuGet package
  (maint) Update to latest Chocolatey package
  (build) Re-enable release notes export
  (maint) Added copyright to nuspec file
  (build) Updated GRM config file
  (maint) Update to released beta packages
  (maint) Switch from int to long
  (maint) Update to latest beta Chocolatey packages
  (maint) Remove @everyone from Discord notification
  (maint) Bump to beta package in nuspec
  (maint) Update to latest beta Chocolatey packages
  (build) Update to latest Chocolatey.Cake.Recipe
  (build) Remove unnecessary configuration
  (build) Add notification templates
  (maint) Prevent download of relase notes
  (#974) Update to released beta packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
5 - Released The issue has been resolved, and released to the public for consumption BreakingChange The issue will introduce backwards incompatible changes
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
4 participants
@gep13 @AdmiringWorm @choco-bot @TheCakeIsNaOH