Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a configuration option to specify a default for a particular source when application loads #808

Closed
adilio opened this issue Feb 5, 2021 · 3 comments
Closed

Add a configuration option to specify a default for a particular source when application loads #808

adilio opened this issue Feb 5, 2021 · 3 comments
Labels
Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Milestone
0.18.0

Comments

@adilio
Copy link

adilio commented Feb 5, 2021

Hi @gep13! Firstly, let me say the work you're doing here is great, and I LOVE using ChocolateyGUI 😁 . I may be biased.

It would be very useful for admins to be able to control which source gets defaulted to when ChocolateyGUI first opens. Something like a "preferredsource" parameter?

Whether this is a C4B-only feature or OSS one, is entirely up to you. Admins have told us numerous times that their end-users aren't always aware enough to know which source to go to by default, as there are often multiple sources. Even if there was some logic to see which source is enabled for self-service, and use that as default, that could work as well.
@adilio adilio added Feature Issues that introduce new functionality to the project, instead of updating existing functionality C4B Feature labels Feb 5, 2021
@ferventcoder ferventcoder added the Customer Bug reported or feature requested by a licensed customer of Chocolatey label Feb 8, 2021
@gep13 gep13 changed the title Feature Request: Default to a particular source Default to a particular source Feb 12, 2021
@gep13 gep13 changed the title Default to a particular source Default to a particular source when application loads Feb 12, 2021
@gep13
Copy link
Member

gep13 commented Feb 12, 2021

@adilio thank you for raising this. I had a chat with @ferventcoder and we decided that this would be a Business Customer feature, which would require an update to the Chocolatey GUI Licensed Extension in order to light up this feature.

Related issue was created here: chocolatey/chocolatey-licensed-issues#198

@gep13 gep13 changed the title Default to a particular source when application loads Add feature toggle to allow defaulting to a particular source when application loads Feb 12, 2021
@gep13 gep13 removed C4B Feature Customer Bug reported or feature requested by a licensed customer of Chocolatey labels Feb 12, 2021
@gep13
Copy link
Member

gep13 commented Feb 12, 2021 •
edited
Loading

NOTE: While this configuration parameter will exist within the OSS version of Chocolatey GUI, it will not be used, and this feature will only be acted on by the Chocolatey GUI Licensed Extension.

@gep13 gep13 changed the title Add feature toggle to allow defaulting to a particular source when application loads Add configuration parameter to specify which source should be defaulted to when application loads Feb 12, 2021
gep13 added a commit that referenced this issue Feb 12, 2021
@gep13
(GH-808) Add config setting for default source
9cf49f1 
This will be used in the Chocolatey GUI Licensed Extension to move to
a default named source when the application first loads.
@gep13 gep13 added this to the 0.18.0 milestone Feb 12, 2021
@gep13 gep13 closed this as completed Feb 12, 2021
@gep13 gep13 reopened this Feb 12, 2021
@gep13 gep13 closed this as completed Feb 12, 2021
gep13 added a commit that referenced this issue Feb 13, 2021
@gep13
(GH-808) Makes SourcesViewModel overridable
2deaf5e 
Slightly re-structure code to make it easier to override the necessary
portions within the Chocolatey GUI Licensed Extension.
@gep13 gep13 mentioned this issue Feb 14, 2021
Closed
gep13 added a commit that referenced this issue Feb 16, 2021
@gep13
(GH-808) Output new config value in ToString
c6cb096 
This was omitted when the configuration parameter was first added.
gep13 added a commit that referenced this issue Feb 22, 2021
@gep13
(GH-808) Fix bug with view activation
46c4a2a 
In an earlier commit for this issue, the _firstLoad logic was removed,
as it was believed that this was no longer required, however, that is
not the case.  This logic is needed to ensure that when returning from
the package details view, that sources aren't incorrectly loaded again.

In addition, it was found that after the earlier changes were made, the
showing of the aggregated source also no longer worked.  Not entirely
sure how this ever worked, as there wasn't a message sent to update the
sources when this feature was activated.  This has now been added.
@gep13 gep13 changed the title Add configuration parameter to specify which source should be defaulted to when application loads Add a configuration option to specify a default for a particular source when application loads Mar 8, 2021
@choco-bot
Copy link

🎉 This issue has been resolved in version 0.18.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Issues that introduce new functionality to the project, instead of updating existing functionality
Projects
None yet
Milestone
0.18.0
Development

No branches or pull requests
4 participants
@ferventcoder @gep13 @choco-bot @adilio