Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release notes in about dialog empty #499

Closed
pascalberger opened this issue Oct 19, 2017 · 3 comments
Closed

Release notes in about dialog empty #499

pascalberger opened this issue Oct 19, 2017 · 3 comments
Labels
Bug Issues where something has happened which was not expected or intended
Milestone
0.16.0

Comments

@pascalberger
Copy link
Contributor

The release notes in the about dialog of the released 0.15 version still reads:

This file will be updated as part of the Chocolatey GUI build process.

If you want to see the current release notes, please check here

Seems like the updating of the file during the build process doesn't work
@gep13
Copy link
Member

gep13 commented Oct 19, 2017

@pascalberger dang it!

No, that part is working, I specifically checked that with @RichiCoder1 when we tagged the branch.

The problem here is that @ferventcoder then built the project again in order to sign the application, as a result, the release notes were not pulled into the build that shipped with 0.15.0.

We are going to need to figure this out for the next release.

Thanks for raising this!

@gep13 gep13 added the Bug Issues where something has happened which was not expected or intended label Oct 19, 2017
@gep13 gep13 added this to the 0.16.0 milestone Oct 19, 2017
@ferventcoder
Copy link
Member

I missed a step then...

@gep13
Copy link
Member

gep13 commented Oct 25, 2017

@ferventcoder no, I wouldn't say that. Rather, Cake.Recipe is built on a few assumptions, namely that the final push/build is happening on a CI system, however, this isn't happening here. I made some assumptions when switching Chocolatey GUI build to not do some steps, and I forgot about this one.

@gep13 gep13 mentioned this issue Nov 18, 2017
Closed
@gep13 gep13 added the BuildAutomation Issues for changes to the build system, without functional changes needed to the project label Nov 19, 2017
gep13 added a commit that referenced this issue Feb 14, 2018
@gep13
(GH-499) Ignore generated documentation
ea444db
gep13 added a commit that referenced this issue Feb 14, 2018
@gep13
(GH-499) Ignore files used by Wyam
ed57d17
gep13 added a commit that referenced this issue Feb 14, 2018
@gep13
(GH-499) Added launch.json file
33bca3f 
- To try to allow debugging of the Cake Script
gep13 added a commit that referenced this issue Feb 14, 2018
@gep13
(GH-499) Minor tweaks to build process
73e46cc 
- Ensure that Transifex Environment Variable name is correct
- Force using specific version of MSBuild Location, so that WiX works on
@gep13 gep13 closed this as completed Feb 14, 2018
@gep13 gep13 removed the BuildAutomation Issues for changes to the build system, without functional changes needed to the project label Feb 14, 2018
gep13 added a commit that referenced this issue Feb 14, 2018
@gep13
Merge branch 'release/0.16.0'
1cdd328 
* release/0.16.0: (82 commits)
  (GH-499) Minor tweaks to build process
  (doc) Minor tweaks to documentation
  (GH-499) Added launch.json file
  (GH-499) Ignore files used by Wyam
  (GH-499) Ignore generated documentation
  Use MahApps search TextBox style instead of regular button.
  Fix "'public' members must come before 'protected' members".
  (GH-527) Change _hasLoaded to CanLoadRemotePackages().
  (GH-527) Added search on enter in RemoteSourceView
  (build) Updated to new version of Cake
  (GH-534) Fixed Application Name
  (GH-524) Fix errors on build from last changes
  (GH-524) Change settings for local and remote view directly
  (GH-524) Added ability to default to Tile View
  (GH-523) Added new/missing translations
  (build) Added local environment variables
  (GH-529) Switch to using Chocolatey Module
  (GH-529) Added packages.config file for Modules
  (build) Updated exclusion pattern
  (build) Updated to latest build.ps1 file
  ...
choco-bot pushed a commit that referenced this issue Feb 14, 2018
@gep13
AppVeyor Publish: 1cdd328
d8e187b 
Merge branch 'release/0.16.0'

* release/0.16.0: (82 commits)
  (GH-499) Minor tweaks to build process
  (doc) Minor tweaks to documentation
  (GH-499) Added launch.json file
  (GH-499) Ignore files used by Wyam
  (GH-499) Ignore generated documentation
  Use MahApps search TextBox style instead of regular button.
  Fix "'public' members must come before 'protected' members".
  (GH-527) Change _hasLoaded to CanLoadRemotePackages().
  (GH-527) Added search on enter in RemoteSourceView
  (build) Updated to new version of Cake
  (GH-534) Fixed Application Name
  (GH-524) Fix errors on build from last changes
  (GH-524) Change settings for local and remote view directly
  (GH-524) Added ability to default to Tile View
  (GH-523) Added new/missing translations
  (build) Added local environment variables
  (GH-529) Switch to using Chocolatey Module
  (GH-529) Added packages.config file for Modules
  (build) Updated exclusion pattern
  (build) Updated to latest build.ps1 file
  ...
choco-bot pushed a commit that referenced this issue Feb 15, 2018
@gep13
AppVeyor Publish: 1cdd328
14448a9 
Merge branch 'release/0.16.0'

* release/0.16.0: (82 commits)
  (GH-499) Minor tweaks to build process
  (doc) Minor tweaks to documentation
  (GH-499) Added launch.json file
  (GH-499) Ignore files used by Wyam
  (GH-499) Ignore generated documentation
  Use MahApps search TextBox style instead of regular button.
  Fix "'public' members must come before 'protected' members".
  (GH-527) Change _hasLoaded to CanLoadRemotePackages().
  (GH-527) Added search on enter in RemoteSourceView
  (build) Updated to new version of Cake
  (GH-534) Fixed Application Name
  (GH-524) Fix errors on build from last changes
  (GH-524) Change settings for local and remote view directly
  (GH-524) Added ability to default to Tile View
  (GH-523) Added new/missing translations
  (build) Added local environment variables
  (GH-529) Switch to using Chocolatey Module
  (GH-529) Added packages.config file for Modules
  (build) Updated exclusion pattern
  (build) Updated to latest build.ps1 file
  ...
DamianMaslanka5 pushed a commit to DamianMaslanka5/ChocolateyGUI that referenced this issue Feb 15, 2018
@gep13 @DamianMaslanka5
(chocolateyGH-499) Ignore generated documentation
a099104
DamianMaslanka5 pushed a commit to DamianMaslanka5/ChocolateyGUI that referenced this issue Feb 15, 2018
@gep13 @DamianMaslanka5
(chocolateyGH-499) Ignore files used by Wyam
c6a2f8d
DamianMaslanka5 pushed a commit to DamianMaslanka5/ChocolateyGUI that referenced this issue Feb 15, 2018
@gep13 @DamianMaslanka5
(chocolateyGH-499) Added launch.json file
34103ca 
- To try to allow debugging of the Cake Script
DamianMaslanka5 pushed a commit to DamianMaslanka5/ChocolateyGUI that referenced this issue Feb 15, 2018
@gep13 @DamianMaslanka5
(chocolateyGH-499) Minor tweaks to build process
efa35ad 
- Ensure that Transifex Environment Variable name is correct
- Force using specific version of MSBuild Location, so that WiX works on
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Milestone
0.16.0
Development

No branches or pull requests
3 participants
@ferventcoder @gep13 @pascalberger