Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dates are displayed in US format not in machine locale format #380

Closed
lionelberton opened this issue Jan 20, 2017 · 4 comments
Closed

Dates are displayed in US format not in machine locale format #380

lionelberton opened this issue Jan 20, 2017 · 4 comments
Assignees
Labels
Bug Issues where something has happened which was not expected or intended
Milestone

Comments

@lionelberton
Copy link

Dates displayed on a package detail view (last update for instance) are displayed in US format whereas the machine date format is French.
Dates times and numbers, should be displayed using the machine locale format.

(Surprisingly package size is in the machine locale already, probably because it is formatted to string through a windows API.)

Localization can be done using a WPF localized binding like this (for instance):

public class LocalizedBinding : Binding
{
    public LocalizedBinding()
        : base()
    {
        this.ConverterCulture = System.Globalization.CultureInfo.CurrentCulture;
    }
    public LocalizedBinding(string path)
        : base(path)
    {
        this.ConverterCulture = System.Globalization.CultureInfo.CurrentCulture;
    }

}

@RichiCoder1
Copy link
Contributor

Huh. I was 99% sure this was an automatic thing. I'll look into fixing this.
(And you're correct about package sizing).

@RichiCoder1 RichiCoder1 self-assigned this Jan 22, 2017
@RichiCoder1 RichiCoder1 added :UI Bug Issues where something has happened which was not expected or intended Up for Grabs Issues that are available by the community to work on labels Jan 22, 2017
@RichiCoder1 RichiCoder1 added this to the 0.15.0 milestone Jan 22, 2017
@RichiCoder1 RichiCoder1 removed the :UI label Feb 14, 2017
@RichiCoder1
Copy link
Contributor

@laperouse Could you verify this is still an issue with the latest prerelease? I believe some work we're doing with localization might have incidentally fixed this.

@RichiCoder1 RichiCoder1 removed the Up for Grabs Issues that are available by the community to work on label May 5, 2017
@AdmiringWorm
Copy link
Member

@RichiCoder1 I can verify that this no longer happens (with the latest build from the develop branch).

image

Everything is correctly formatting according to my locale.

@RichiCoder1
Copy link
Contributor

Glad to hear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues where something has happened which was not expected or intended
Projects
None yet
Development

No branches or pull requests

3 participants