JpPrefecture::Prefecture.find(name: xxx)の挙動を修正 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -115,6 +115,9 @@ def self.all | |||
| # @return [Integer] 見つかった場合は都道府県コード | |||
| # @return [nil] 見つからない場合は nil | |||
| def self.find_code_by_name(name) | |||
| # nameがnil、空文字の場合は見つからないと判断してnilを返す。 | |||
There was a problem hiding this comment.
コードだけで説明できていますので、コメントは削除してもらっても良いですか？
|
コメントを削除したので、再度ご確認お願いします。 |
|
確認しました |
ありがとうございます 👏
|
v0.8.1 としてリリースしました 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18 のIssueに対する修正です。
引数に空文字、nilを与えた場合にnilを返すようにしました。
よろしくお願いしますm(_ _)m