Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deal with SCSS deprecation warnings #50

Open
lmullen opened this issue Aug 4, 2021 · 1 comment
Open

Deal with SCSS deprecation warnings #50

lmullen opened this issue Aug 4, 2021 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@lmullen
Copy link
Member

lmullen commented Aug 4, 2021

I get these deprecation warnings:

DEPRECATION WARNING on line 115 of /Users/lmullen/github/religious-ecologies/website/node_modules/foundation-sites/scss/util/_color.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$primary-color: null` at the top level.

DEPRECATION WARNING on line 120 of /Users/lmullen/github/religious-ecologies/website/node_modules/foundation-sites/scss/util/_color.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$secondary-color: null` at the top level.

DEPRECATION WARNING on line 125 of /Users/lmullen/github/religious-ecologies/website/node_modules/foundation-sites/scss/util/_color.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$success-color: null` at the top level.

DEPRECATION WARNING on line 130 of /Users/lmullen/github/religious-ecologies/website/node_modules/foundation-sites/scss/util/_color.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$warning-color: null` at the top level.

DEPRECATION WARNING on line 135 of /Users/lmullen/github/religious-ecologies/website/node_modules/foundation-sites/scss/util/_color.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$alert-color: null` at the top level.

DEPRECATION WARNING on line 164 of /Users/lmullen/github/religious-ecologies/website/node_modules/foundation-sites/scss/util/_breakpoint.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$-zf-size: null` at the top level.

DEPRECATION WARNING on line 369 of /Users/lmullen/github/religious-ecologies/website/node_modules/foundation-sites/scss/util/_mixins.scss:
!global assignments won't be able to declare new variables in future versions.
Consider adding `$-zf-bp-value: null` at the top level.
@hepplerj hepplerj self-assigned this Aug 5, 2021
@hepplerj
Copy link
Member

hepplerj commented Aug 5, 2021

After a bit of research this morning, it appears this is a known issue in foundation-sites v6, and there are plans--though not a clear roadmap--for version 7 (see #11847). Foundation is no longer actively maintained by ZURB developers and has been turned over to open source volunteers.

Their focus seems to be on version 7 and a timeline on maintenance seems uncertain, so I'd recommend we make a simple change to app.scss to set those !global declarations to null as suggested in the depreciation warnings. I'll push an update for those shortly.

I'd also say let's keep this issue open for now and I'll keep an eye on things over at foundation-sites in the event an update comes from them.

@hepplerj hepplerj added the bug Something isn't working label Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants