Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform keyboard shortcuts for the wiki #1701

Open
ajainuary opened this issue Jun 4, 2019 · 1 comment
Open

Cross-platform keyboard shortcuts for the wiki #1701

ajainuary opened this issue Jun 4, 2019 · 1 comment

Comments

@ajainuary
Copy link
Collaborator

The current keyboard shortcuts don't work beyond Mac because of lack of Command Key on other platforms. We would either need to change the keyboard shortcuts all together or have platform specific key bindings (e.g. Ctrl+N on Ubuntu opens a new Chrome Window instead of creating a new page on the Wiki).

@qgolsteyn
Copy link
Collaborator

qgolsteyn commented Jun 4, 2019

Pretty much all keyboard press events can be overriden and their default behavior can be stopped. This can be done from the key press event as follow:

disabledEventPropagation(e);
e.preventDefault();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants