Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generic editor #219

Merged
merged 69 commits into from
Jul 25, 2024
Merged

Generic editor #219

merged 69 commits into from
Jul 25, 2024

Conversation

targos
Copy link
Member

@targos targos commented Jul 19, 2024 •
edited
Loading

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 19, 2024 •
edited
Loading

Deploying openchemlib-js with  Cloudflare Pages  Cloudflare Pages

Latest commit: a4bcddb
Status: ✅  Deploy successful!
Preview URL: https://b3495d87.openchemlib-js.pages.dev
Branch Preview URL: https://generic-editor.openchemlib-js.pages.dev

View logs

@targos targos linked an issue Jul 19, 2024 that may be closed by this pull request
Expose Generic* stuff to JavaScript #136
Closed
targos and others added 17 commits July 22, 2024 16:11
@targos
chore: remove unused imports
416a4ee
@targos
chore: migrate poc page to ts
a470dce
@tpoisseau
fix: grabFocus from java preventScroll now
2fb5012 
Refs: #136
@tpoisseau
fix(Dialog): button ok on the right, cancel on the left
cf77094 
Refs: #136
@targos
docs: add jsdoc to all CanvasEditor methods
e0ed340
@targos
chore: use correct hashbang in get-* scripts
7728439
@targos
refactor: extract UI helper to separate class and use 16px cursor
579a66e
@tpoisseau
chore: add idea config for java modules
57451bf
@tpoisseau
fix: repaint editor area after Dialog fireOk
00a07e7
@tpoisseau
fix: properly bind clickCount from dom mouse events to java fireMouse…
e1c5007 
…Event
@targos
fix: use 24px size for cursors
ec567e3
@targos
fix: implement drawRectangle
9d60d9f
@tpoisseau
feat: add readonly mode
5951f11
@tpoisseau
Merge remote-tracking branch 'origin/generic-editor' into generic-editor
9c0eb44
@targos
refactor: move readOnly to an options object
581bba4
@targos
feat: add destroy method for cleanup
03ccf21
@targos
feat: add support for touch screens
aecd411
targos and others added 26 commits July 25, 2024 08:15
@targos
refactor: use animation frame to repaint editor area
a915040
@targos
refactor: init of canvas editor
f5422f0
@targos
feat: add getMode method
8b8cb07 
Display RXN when in reaction mode.
@targos
docs: empty all results on reset
2a79004
@targos
docs: remove unused variable
467259a
@targos
chore: update exposed name
f7eda57
@tpoisseau
chore: continue implem of custom element
1e542ac
@tpoisseau
Merge remote-tracking branch 'origin/generic-editor' into generic-editor
a3c6b70
@targos
fix: allow backspace for delete actions
5a787be
@targos
fix: add more checks for not destroyed
55d9760
@targos
fix: only create toolbar canvas if needed
e67a254
@targos
docs: add readonly option to init and display molfile v2
ba0e4fb
@targos
feat: add initialFragment option and trigger update on dialog submit
dc6cb18
@targos
chore: update submodule
420361b
@targos
fix: rxn v3 bug
898d829 
Refs: Actelion/openchemlib#111
@targos
test: update snapshot
c2c9393
@tpoisseau
chore: continue implem of custom element
8e1d4b9
@tpoisseau
chore: cast dom attributes values
0b67d9c
@tpoisseau
fix: chromium derived do not support custom element extending builtin…
d486cdc 
… element
@tpoisseau
fix: init and document styling
0bab565
@targos
fix: center dialog and isolate it with shadow dom
220bfde
@targos
fix: remove shadow root from custom element
282d6a2
@targos
refactor: do not init for nothing
959e16d
@tpoisseau
fix: run mutatorHandler if this.#editor is defined
d0de3da
@targos
chore: run Prettier
70bacec
@targos
docs: keep default height
a4bcddb
@targos targos changed the title [wip] Generic editor Generic editor Jul 25, 2024
@targos targos merged commit 8a8185f into main Jul 25, 2024
5 checks passed
@targos targos deleted the generic-editor branch July 25, 2024 14:28
@cheminfo-bot cheminfo-bot mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose Generic* stuff to JavaScript
2 participants
@targos @tpoisseau