Net fetcher cannot download from Basic Auth URLs

[LeeXGreen]

Description

I'm using omnibus to build my software. One of my dependencies needs to be downloaded from an authenticated URL (Basic auth, if it matters). I'd like to be able to use the Net fetcher for this.

I'd like to submit a PR to fix this, if it would be welcomed.

Omnibus Version

5.6, also 6.0.1

Platform Version

Debian Stretch -- output of uname -a:

Linux 929970e3a45d 4.9.93-linuxkit-aufs #1 SMP Wed Jun 6 16:55:56 UTC 2018 x86_64 GNU/Linux

Replication Case

I tried embedding the username and password in the URL, like this:
https://user:[email protected]/path/to/the/file.tar.gz
This didn't work and raised the error below.
I also tried passing a URI instead of a String. This raised the same error.

Build Output

/usr/local/lib/ruby/2.5.0/open-uri.rb:276:in `open_http': userinfo not supported. [RFC3986] (ArgumentError) from /usr/local/lib/ruby/2.5.0/open-uri.rb:755:in `buffer_open' from /usr/local/lib/ruby/2.5.0/open-uri.rb:226:in `block in open_loop' from /usr/local/lib/ruby/2.5.0/open-uri.rb:224:in `catch' from /usr/local/lib/ruby/2.5.0/open-uri.rb:224:in `open_loop' from /usr/local/lib/ruby/2.5.0/open-uri.rb:165:in `open_uri' from /builds/olympus/omnibus-tron/.bundle/ruby/2.5.0/gems/omnibus-5.6.8/lib/omnibus/core_extensions/open_uri.rb:51:in `open_uri' from /usr/local/lib/ruby/2.5.0/open-uri.rb:735:in `open' from /usr/local/lib/ruby/2.5.0/open-uri.rb:35:in `open' from /builds/olympus/omnibus-tron/.bundle/ruby/2.5.0/gems/omnibus-5.6.8/lib/omnibus/download_helpers.rb:80:in `download_file!' from /builds/olympus/omnibus-tron/.bundle/ruby/2.5.0/gems/omnibus-5.6.8/lib/omnibus/fetchers/net_fetcher.rb:173:in `download' from /builds/olympus/omnibus-tron/.bundle/ruby/2.5.0/gems/omnibus-5.6.8/lib/omnibus/fetchers/net_fetcher.rb:86:in `fetch' from /builds/olympus/omnibus-tron/.bundle/ruby/2.5.0/gems/omnibus-5.6.8/lib/omnibus/software.rb:897:in `fetch' from /builds/olympus/omnibus-tron/.bundle/ruby/2.5.0/gems/omnibus-5.6.8/lib/omnibus/project.rb:1066:in `block (3 levels) in download' from /builds/olympus/omnibus-tron/.bundle/ruby/2.5.0/gems/omnibus-5.6.8/lib/omnibus/thread_pool.rb:64:in `block (4 levels) in initialize' from /builds/olympus/omnibus-tron/.bundle/ruby/2.5.0/gems/omnibus-5.6.8/lib/omnibus/thread_pool.rb:62:in `loop' from /builds/olympus/omnibus-tron/.bundle/ruby/2.5.0/gems/omnibus-5.6.8/lib/omnibus/thread_pool.rb:62:in `block (3 levels) in initialize' from /builds/olympus/omnibus-tron/.bundle/ruby/2.5.0/gems/omnibus-5.6.8/lib/omnibus/thread_pool.rb:61:in `catch' from /builds/olympus/omnibus-tron/.bundle/ruby/2.5.0/gems/omnibus-5.6.8/lib/omnibus/thread_pool.rb:61:in `block (2 levels) in initialize'