bugfix: unindent description misbehaviors #1707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh my, finally fixed this... 😁 |
arlimus
commented
Apr 25, 2017
| end | ||
|
|
||
| it 'adds a multiline description' do | ||
| t = rand_string + "\n" + rand_string |
There was a problem hiding this comment.
for example, this was not working with the old method, it would just replace the newline character
arlimus
commented
Apr 25, 2017
| end | ||
|
|
||
| it 'strips empty lines and spaces in description at start and end' do | ||
| t = " \n" + rand_string + "\n " |
There was a problem hiding this comment.
add tests for this behavior, make sure we don't break anyone unexpectedly
Unindent has been misbehaving for control `desc`riptions by completely removing newlines. This is now fixed and the unindentation mechanism improved to behave as expected. Removing empty lines at the beginning and end of string remains unchanged. Tabs are not treated as multi-space indentations; supporting them as 8-space chars would require additional effort (please comment if this is important to you) Signed-off-by: Dominik Richter <[email protected]>
arlimus
force-pushed
the
dr/fix-unindent
branch
from
06f61ab
to
37a2e45
Compare
chris-rock
approved these changes
Apr 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unindent has been misbehaving for control
descriptions by completely removing newlines. This is now fixed and the unindentation mechanism improved to behave as expected.Removing empty lines at the beginning and end of string remains unchanged.
Tabs are not treated as multi-space indentations; supporting them as 8-space chars would require additional effort (please comment if this is important to you)
Signed-off-by: Dominik Richter [email protected]