Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS support #6

Open
smith opened this issue Oct 23, 2014 · 3 comments
Open

CORS support #6

smith opened this issue Oct 23, 2014 · 3 comments
Labels
Aspect: Security Can an unwanted third party affect the stability or look at privileged information? Status: To be prioritized Indicates that product needs to prioritize this issue. Type: Enhancement Adds new functionality.

Comments

@smith
Copy link
Contributor

smith commented Oct 23, 2014

As a user, I would like Chef server responses to contain Cross Origin Resource Sharing headers so I can use the Chef server with HTTP clients that have a same-origin security policy.

This could be implemented by including some Nginx configuration and attributes in the configuration that could customize that configuration for my Chef server.

Basic support for this is enabled in Chef Zero.

@stevendanna stevendanna added this to the accepted-minor milestone May 13, 2015
@cnunciato
Copy link

CORS would be nice, but what would you pass along with these requests in terms of auth creds? This seems like something maybe oc-id might be better suited for.

@mmzyk
Copy link
Contributor

mmzyk commented May 13, 2015

From discussion of this amongst Team VI:

Without CORS support you can never build a single page javascript app that talks directly to the server. A proxy will always be needed, but needing a proxy is silly, b/c the server already talks http.

Nathan points out that:

With chef-zero right now, I can pop in a console and do jQuery.get("http://localhost:8889/nodes").then(function (nodes) { console.log("woot nodes!", nodes); });
I get a same origin error if I try that against a real chef server

@mmzyk
Copy link
Contributor

mmzyk commented May 13, 2015

Further discussion, from Nathan Smith, in response to Chris' question about auth creds:

You would need token auth (https://github.com/chef/chef-rfc/blob/master/rfc038-token-authentication.md) to make it useful at all, but token auth would be useless for a browser-based app without CORS.

oc-id could be the token provider or maybe not.

@tas50 tas50 added Type: Enhancement Adds new functionality. and removed enhancement labels Jan 4, 2019
@PrajaktaPurohit PrajaktaPurohit added Status: To be prioritized Indicates that product needs to prioritize this issue. Triage: Try Reproducing Indicates that this issue needs to be reproduced. labels Jul 31, 2020
@stevendanna stevendanna removed this from the accepted-minor milestone Sep 29, 2020
@tas50 tas50 added Aspect: Security Can an unwanted third party affect the stability or look at privileged information? and removed Triage: Try Reproducing Indicates that this issue needs to be reproduced. labels Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Aspect: Security Can an unwanted third party affect the stability or look at privileged information? Status: To be prioritized Indicates that product needs to prioritize this issue. Type: Enhancement Adds new functionality.
Projects
None yet
Development

No branches or pull requests

6 participants