Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbid deletion of special groups (users, clients, admins, billing-admins) #123

Open
markan opened this issue Mar 6, 2015 · 1 comment
Labels
Status: Good First Issue An issue ready for a new contributor. Status: To be prioritized Indicates that product needs to prioritize this issue. Triage: Try Reproducing Indicates that this issue needs to be reproduced. Type: Enhancement Adds new functionality.

Comments

@markan
Copy link
Contributor

markan commented Mar 6, 2015

We currently allow users to delete 'special' groups.

A common example is someone deleting the users group. This horribly breaks user association, and because of the way ACLs are implemented is difficult to recover from since every single object will a require ACL fix to add users back.

We should forbid deletion of those groups. Probably the most straightforward way is to add a whitelist of groups that must not be deleted and check them in oc_chef_wm_named_group:delete_resource function.

@marcparadise
Copy link
Member

👍 to this issue/change. Internally we rely on the presence of these groups (in particular admins and users) and make assumptions based on their existence.

@sdelano sdelano added this to the accepted-minor milestone Jun 10, 2015
@tas50 tas50 added Type: Enhancement Adds new functionality. and removed enhancement labels Jan 4, 2019
@PrajaktaPurohit PrajaktaPurohit added Status: To be prioritized Indicates that product needs to prioritize this issue. Status: Good First Issue An issue ready for a new contributor. Triage: Try Reproducing Indicates that this issue needs to be reproduced. and removed ready labels Jul 17, 2020
@stevendanna stevendanna removed this from the accepted-minor milestone Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Good First Issue An issue ready for a new contributor. Status: To be prioritized Indicates that product needs to prioritize this issue. Triage: Try Reproducing Indicates that this issue needs to be reproduced. Type: Enhancement Adds new functionality.
Projects
None yet
Development

No branches or pull requests

6 participants