-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why not release 2.0.0?, all our repos are breaking without warning #4084
Comments
Cheerio was in RC, meaning it can change as it wishes until the official release. Pinning dependencies is crucial and especially crucial when using experimental packages. |
Maybe I'm missing something here, but rc12 is completely different to how the bundle looks from 1.0, and how it's consumed..... It goes from a "lib" directory with transpiled code (looks like es5 target, but I could be wrong) -- into type=module, a "dist" directory with js files having "import/export" statements..... and, "1.0.0" is an in-range update of "^1.0.0-rc.12" For my two cents, I ran an npm update and jest started screaming at me about unexpected export syntax and failed all my tests. Anyone who is using enzyme in their scripts with jest and runs an + "overrides": {
+ "enzyme": {
+ "cheerio": "1.0.0-rc.12"
+ }
+ }, I agree with OP. Publish 1.01 as an alias of 1.0.0-rc.12, deprecate 1.0.0, and publish whatever cheerio is today as 2.0 |
I am super excited and appreciate cheerio reaches a new milestone.
Indeed. Normally a release candidate version should not introduce new breaking changes. And release candate version should just hold a small period of time, not 7 years.... It will be great, if it is possible to
|
Same issue here. In my case, the changes broke our rollup compilation with super-weird issues (something pointing to the parsing of code tables). It took me hours to track down the root issue: Another dev of our team had added I can understand that a RC might still contain breaking changes. But if they are so fundamental, this can really break things unexpectedly. BTW: I wasn't aware until this point that a -rc2 prefix will automatically be resolved to the released version once it gets published. |
No description provided.
The text was updated successfully, but these errors were encountered: