Issue #124: Implement recipe for NewlineAtEndOfFile #125
Conversation
Anmol202005
force-pushed
the
eol
branch
15 times, most recently
from
8b311bc to
e5cc5a3
Compare
|
Finally got CI GREEN. @rdiachenko pls review :) |
|
@romani @rdiachenko ping. |
src/main/java/org/checkstyle/autofix/recipe/NewlineAtEndOfFile.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkstyle/autofix/recipe/NewlineAtEndOfFile.java
Outdated
Show resolved
Hide resolved
src/main/java/org/checkstyle/autofix/recipe/NewlineAtEndOfFile.java
Outdated
Show resolved
Hide resolved
| final Space eof = sourceFile.getEof(); | ||
| final String lastWhitespace = eof.getLastWhitespace(); | ||
|
|
||
| if (!lineEnding.equals(lastWhitespace)) { |
There was a problem hiding this comment.
we do not trust checkstyle violation ? or it is save check in case of second execution.
There was a problem hiding this comment.
this is a check for second execution.
src/main/java/org/checkstyle/autofix/recipe/NewlineAtEndOfFile.java
Outdated
Show resolved
Hide resolved
Anmol202005
force-pushed
the
eol
branch
2 times, most recently
from
6d359ff to
a4eac5f
Compare
romani
left a comment
romani
left a comment
There was a problem hiding this comment.
Do we need explicitly add this recipe to checkstyle main repo config to be executed by CI ?
thansk a lot for your work.
|
|
@rdiachenko , please finish review |
|
@Anmol202005 please update README with proper links to a new recipe, and ok to merge after that |
|
After rebase , there might be some pitest mutations, just add them to suppression. No suppression rule will be enforced after this PR |
|
@Anmol202005 , if you send PR for #127 (comment), system will print patch for suppression and it will be easy to update suppression. |
3 participants
Fixes: #124
Implemented recipe for NewlineAtEndOfFile: https://checkstyle.sourceforge.io/checks/misc/newlineatendoffile.html