Fix mysql8 compatibility #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
=======================================
Coverage 83.01% 83.01%
=======================================
Files 27 27
Lines 1755 1755
=======================================
Hits 1457 1457
Misses 214 214
Partials 84 84
Continue to review full report at Codecov.
|
zhouzhuojie
commented
Sep 5, 2020
| MYSQL_ALLOW_EMPTY_PASSWORD: "yes" | ||
| MYSQL_DATABASE: "flagr" | ||
| MYSQL_USER: "root" | ||
|
|
There was a problem hiding this comment.
added integration tests for mysql 5.6 and mysql 8
zhouzhuojie
commented
Sep 5, 2020
| Preload("Segments", func(db *gorm.DB) *gorm.DB { | ||
| return PreloadConstraintsDistribution(db). | ||
| Order("rank ASC"). | ||
| Order("id ASC") | ||
| Order("rank"). |
There was a problem hiding this comment.
"rank ASC" was not escaped correctly in mysql8 due to the new keyword RANK function. Here we can just remove ASC and let gorm handle the field name escape correctly.
zhouzhuojie
force-pushed
the
zz/fix-mysql-compatibility
branch
from
3c29f43 to
4ad0a8e
Compare
marceloboeira
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix mysql8 compatibility by removing the unnecessary "ASC" keyword in preload gorm queries.
The actual root cause is that
Rankis a new keyword in mysql8, and we need to safely escape that for MySQL and Postgres.Tried a few solutions, and the safest is actually remove the "ASC" so that gorm can handle the name escape correctly for mysql and postgres.
Description
Fix #386
Motivation and Context
How Has This Been Tested?
Tested locally for mysql 5.6 and mysql 8+.
Tested in integration tests.
Types of changes
Checklist: