Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update conditions to include dash constraint #390

Merged
merged 1 commit into from
Aug 21, 2020

Conversation

zhouzhuojie
Copy link
Collaborator

Description

Setting the condition's property name with - in it will cause a 400 like:
image

image

Related PR in zhouzhuojie/conditions#13

Motivation and Context

How Has This Been Tested?

Unit tests and local tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zhouzhuojie zhouzhuojie force-pushed the zz/update-conditions-to-include-dash-constraint branch from 300f8c0 to 6c340e8 Compare August 21, 2020 01:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2020

Codecov Report

Merging #390 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   83.01%   83.01%           
=======================================
  Files          27       27           
  Lines        1755     1755           
=======================================
  Hits         1457     1457           
  Misses        214      214           
  Partials       84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c5e30c...6c340e8. Read the comment docs.

@zhouzhuojie
Copy link
Collaborator Author

cc @wmak

Copy link

@wmak wmak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 Thanks for merging this so quickly, tested this and it looks good to me 👍

@zhouzhuojie zhouzhuojie merged commit 936e123 into master Aug 21, 2020
@zhouzhuojie zhouzhuojie deleted the zz/update-conditions-to-include-dash-constraint branch August 21, 2020 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants