Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users the ability to restore deleted flags #379

Merged
merged 6 commits into from
Jul 29, 2020
Merged

Allow users the ability to restore deleted flags #379

merged 6 commits into from
Jul 29, 2020

Conversation

silent1mezzo
Copy link
Contributor

@silent1mezzo silent1mezzo commented Jul 22, 2020

This allows users to restore delete flags from the main page.

Fixes #215 and partially solves #255

Screen Shot 2020-07-22 at 2 01 00 PM

@silent1mezzo
Copy link
Contributor Author

This is the first time working in Vue or Go so feel free to point out where I can improve the code.

@@ -84,6 +84,49 @@
</template>
</el-table-column>
</el-table>

<h2>Deleted Flags</h2>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if using https://element.ele.me/#/en-US/component/collapse#collapse and wrap the new el-table with lazy loading can help improve the first page loading time, and also the restore deleted flags may not be a frequent usage to be always shown, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhouzhuojie sounds good. I just updated it so it hides the Deleted flags and only loads them when a user clicks on the collapsed table.

pkg/handler/crud.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #379 into master will decrease coverage by 0.15%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage   83.17%   83.01%   -0.16%     
==========================================
  Files          27       27              
  Lines        1736     1755      +19     
==========================================
+ Hits         1444     1457      +13     
- Misses        211      214       +3     
- Partials       81       84       +3     
Impacted Files Coverage Δ
pkg/handler/crud.go 88.02% <68.42%> (-1.01%) ⬇️
pkg/handler/handler.go 83.63% <100.00%> (+0.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6967eed...0348df6. Read the comment docs.

@silent1mezzo silent1mezzo requested a review from zhouzhuojie July 29, 2020 14:27
pkg/handler/crud.go Outdated Show resolved Hide resolved
Co-authored-by: Zhuojie Zhou <[email protected]>
@silent1mezzo
Copy link
Contributor Author

Thanks for the catch on that API endpoint @zhouzhuojie

Copy link
Collaborator

@zhouzhuojie zhouzhuojie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! I may tune a little bit for the css in the following PR, hope you don't mind.

@zhouzhuojie zhouzhuojie merged commit 8d4ca38 into openflagr:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] restore deleted flags
3 participants