-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users the ability to restore deleted flags #379
Conversation
This is the first time working in Vue or Go so feel free to point out where I can improve the code. |
@@ -84,6 +84,49 @@ | |||
</template> | |||
</el-table-column> | |||
</el-table> | |||
|
|||
<h2>Deleted Flags</h2> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if using https://element.ele.me/#/en-US/component/collapse#collapse and wrap the new el-table with lazy loading can help improve the first page loading time, and also the restore deleted flags may not be a frequent usage to be always shown, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhouzhuojie sounds good. I just updated it so it hides the Deleted flags and only loads them when a user clicks on the collapsed table.
Co-authored-by: Zhuojie Zhou <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
- Coverage 83.17% 83.01% -0.16%
==========================================
Files 27 27
Lines 1736 1755 +19
==========================================
+ Hits 1444 1457 +13
- Misses 211 214 +3
- Partials 81 84 +3
Continue to review full report at Codecov.
|
Co-authored-by: Zhuojie Zhou <[email protected]>
Thanks for the catch on that API endpoint @zhouzhuojie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I may tune a little bit for the css in the following PR, hope you don't mind.
This allows users to restore delete flags from the main page.
Fixes #215 and partially solves #255