Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 get flag test #337

Merged
merged 1 commit into from
Mar 19, 2020
Merged

Add 404 get flag test #337

merged 1 commit into from
Mar 19, 2020

Conversation

zhouzhuojie
Copy link
Collaborator

Description

Add a simple unit test that covers #318

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zhouzhuojie zhouzhuojie force-pushed the zz/add-404-get-flag-test branch from 11b7ca8 to 50c40f5 Compare March 19, 2020 21:24
@codecov-io
Copy link

Codecov Report

Merging #337 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   81.75%   81.75%           
=======================================
  Files          26       26           
  Lines        1540     1540           
=======================================
  Hits         1259     1259           
  Misses        211      211           
  Partials       70       70           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0febaaf...50c40f5. Read the comment docs.

@zhouzhuojie zhouzhuojie merged commit d8436c1 into master Mar 19, 2020
@zhouzhuojie zhouzhuojie deleted the zz/add-404-get-flag-test branch March 19, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants