Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkr is not thread safe #64

Open
slbug opened this issue Feb 4, 2020 · 5 comments
Open

Checkr is not thread safe #64

slbug opened this issue Feb 4, 2020 · 5 comments

Comments

@slbug
Copy link

slbug commented Feb 4, 2020

If you are have to use multiple api_base / api_key setting it won't be thread safe.

@slbug slbug changed the title Checkr class is not thread safe Checkr is not thread safe Feb 4, 2020
@nothingisfunny
Copy link
Contributor

@slbug Hi, unfortunately this is a known issue, which will be addressed in the future v2 of the gem. As for now, version 1.5.4 and up provides a workaround of passing the api_key directly to the requests:
7537da0
Hope this helps for now.
Thanks for raising the issue and bringing this to our attention!

@slbug
Copy link
Author

slbug commented Feb 6, 2020

Thanks for answer, I know about api_key, but there is no option to pass api_base same way.

@nothingisfunny nothingisfunny reopened this Feb 6, 2020
@nothingisfunny
Copy link
Contributor

@slbug Makes sense, let me look into this and see if we can add a fix.

@nothingisfunny
Copy link
Contributor

@slbug Could you provide me with an example of a use case you struggled with that required a different api_base? That'd help a lot, thanks

@slbug
Copy link
Author

slbug commented Feb 7, 2020

@nothingisfunny i have multiple hosts for api_base. Don't know why, but it's required :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants