Fix #19: [DE] 500th anniversay of the Reformation

Author: FlorianKoerner

lib/Checkdomain/Holiday/Provider/AbstractProvider.php

@@ -23,7 +23,7 @@ public function getHolidayByDate(\DateTime $date, $state = null)
     {
         $day = $date->format(self::DATE_FORMAT);
 
-        $holidays = $this->getHolidaysByYear($date->format('Y'));
+        $holidays = $this->getHolidaysByYear(intval($date->format('Y')));
 
         if (isset($holidays[$day])) {
             $holiday = $this->createModelFromData($holidays[$day], $date);

lib/Checkdomain/Holiday/Provider/DE.php

@@ -37,6 +37,20 @@ public function getHolidaysByYear($year)
     {
         $easter = $this->getEasterDates($year);
 
+        // 500th anniversay of the Reformation
+        // @see https://de.wikipedia.org/wiki/Reformationstag#Deutschland
+        if (2017 === $year) {
+            $reformationDayStates = null;
+        } else {
+            $reformationDayStates = array(
+                self::STATE_BB,
+                self::STATE_MV,
+                self::STATE_SN,
+                self::STATE_ST,
+                self::STATE_TH,
+            );
+        }
+
         $holidays = array(
             // Fixed dates
             '01-01' => $this->createData('Neujahr'),
@@ -51,13 +65,7 @@ public function getHolidaysByYear($year)
                 self::STATE_BY,
                 self::STATE_ST,
             )),
-            '10-31' => $this->createData('Reformationstag', array(
-                self::STATE_BB,
-                self::STATE_MV,
-                self::STATE_SN,
-                self::STATE_ST,
-                self::STATE_TH,
-            )),
+            '10-31' => $this->createData('Reformationstag', $reformationDayStates),
             '11-01' => $this->createData('Allerheiligen', array(
                 self::STATE_BW,
                 self::STATE_BY,

tests/Checkdomain/Holiday/Provider/DETest.php

@@ -31,6 +31,12 @@ public function dateProvider()
             array('2014-06-19', DE::STATE_SH, null),
             array('2014-11-01', DE::STATE_BW, array('name' => 'Allerheiligen')),
             array('2014-11-01', DE::STATE_SH, null),
+            array('2016-10-31', DE::STATE_SH, null),
+            array('2016-10-31', DE::STATE_BB, array('name' => 'Reformationstag')),
+            array('2017-10-31', DE::STATE_SH, array('name' => 'Reformationstag')),
+            array('2017-10-31', DE::STATE_BB, array('name' => 'Reformationstag')),
+            array('2018-10-31', DE::STATE_SH, null),
+            array('2018-10-31', DE::STATE_BB, array('name' => 'Reformationstag')),
         );
     }
 }