Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ICourse and ICoursesWithSessions types #761

Open
2 tasks
eleanorreem opened this issue Jan 28, 2025 · 0 comments
Open
2 tasks

Replace ICourse and ICoursesWithSessions types #761

eleanorreem opened this issue Jan 28, 2025 · 0 comments
Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days javascript Pull requests that update Javascript code priority: soon Should be prioritized soon. state: approved Ready to go. Not blocked or pending.

Comments

@eleanorreem
Copy link
Contributor

eleanorreem commented Jan 28, 2025

Overview

We have types which are prefixed with I[Type] such as ICourse. We are moving to only using Entity types such as CourseEntity in the services and Dtos such GetCourseDto in the controllers.

In cases where ICourse and ICoursesWithSessions is being used in the controller or the entity, convert to the appropriate type. Feel free to use Partials or Pick types if you think it is necessary but preferable to keep it clean and simple.

Action Items

List the research to be done and the steps to be completed.

  • Take a look at CourseEntity and the GetCourseDto and at the GetCourseUserDto and see where they cross over.
  • Replace all instances of ICourse and ICoursesWithSessions with appropriate types. If its not obvious, feel free to tag @eleanorreem or @annarhughes in the comment to ask any questions.
@eleanorreem eleanorreem added complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days priority: soon Should be prioritized soon. state: approved Ready to go. Not blocked or pending. javascript Pull requests that update Javascript code labels Jan 28, 2025
@eleanorreem eleanorreem changed the title Replace ICourse and ICourseUser types Replace ICourse and ICoursesWithSessions types Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: moderate Time needed to do this ticket will be moderate e.g. 1-2 days javascript Pull requests that update Javascript code priority: soon Should be prioritized soon. state: approved Ready to go. Not blocked or pending.
Projects
None yet
Development

No branches or pull requests

1 participant