Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix!: style size to include borders #451

Merged
merged 6 commits into from
Jan 9, 2025
Merged

fix!: style size to include borders #451

merged 6 commits into from
Jan 9, 2025

Conversation

bashbunni
Copy link
Member

@bashbunni bashbunni commented Dec 2, 2024 •
edited
Loading

included tests for these changes that fail on master but pass on this branch :)

@bashbunni bashbunni linked an issue Dec 2, 2024 that may be closed by this pull request
fix!: Style's Width doesn't include border size #449
Open
@aymanbagabas aymanbagabas changed the title fix: fix style size to include borders fix: style size to include borders Dec 2, 2024
bashbunni
bashbunni commented Dec 2, 2024
View reviewed changes
examples/layout/main.go Outdated Show resolved Hide resolved
@bashbunni
Copy link
Member Author

bashbunni commented Dec 3, 2024 •
edited
Loading

@meowgorithm Should this change be part of v2 given it may break some layouts?

This change causes a lot of existing examples to be off by 1 or two depending on if the border is only on one side or not. Authors are currently working around by having x +/- 1 or x +/- 2 when working with bordered content. You can see this in our layout example.

That makes this change breaking despite it being the intended behaviour for Width...

edit: Will include this in v2 since it is breaking

@bashbunni bashbunni mentioned this pull request Dec 3, 2024
Merged
@bashbunni bashbunni changed the title fix: style size to include borders fix!: style size to include borders Dec 3, 2024
@bashbunni bashbunni added the v2 label Dec 3, 2024
@bashbunni bashbunni changed the base branch from master to v2-exp December 16, 2024 15:49
@bashbunni bashbunni changed the base branch from v2-exp to master December 16, 2024 15:50
@bashbunni bashbunni changed the base branch from master to v2-exp January 7, 2025 15:24
@bashbunni
Copy link
Member Author

image
updated to use v2-exp as base branch

@bashbunni bashbunni merged commit 727d393 into v2-exp Jan 9, 2025
19 checks passed
@bashbunni bashbunni deleted the fix-style-sizing branch January 9, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowgorithm meowgorithm Awaiting requested review from meowgorithm meowgorithm is a code owner

@aymanbagabas aymanbagabas Awaiting requested review from aymanbagabas aymanbagabas is a code owner

Assignees
No one assigned
Labels
v2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix!: Style's Width doesn't include border size
1 participant
@bashbunni