generated completion invalid for fish shell

[nate-duke]

Describe the bug
A recent change rendered the generated completion files for the fish shell with a quoting issue. The issue is a pair of single quotes around an asterisk.

complete -c gum -f -n '__fish_seen_subcommand_from choose' -x -l selected -d 'Options that should start as selected (selects all if given '*')'

To Reproduce
Steps to reproduce the behavior:

1. install gum (i did this via homebrew for linux)
2. use fish shell
3. See error

Expected behavior
No parsing errors in completion scripts.

Screenshots

/home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/gum.fish (line 24): No matches for wildcard ''Options that should start as selected (selects all if given '*')''. See `help wildcards-globbing`.
complete -c gum -f -n '__fish_seen_subcommand_from choose' -x -l selected -d 'Options that should start as selected (selects all if given '*')'
                                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
from sourcing file /home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/gum.fish
        called on line 8 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
        called during startup
/home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/gum.fish (line 91): No matches for wildcard ''Options that should start as selected (selects all if given '*')''. See `help wildcards-globbing`.
complete -c gum -f -n '__fish_seen_subcommand_from filter' -x -l selected -d 'Options that should start as selected (selects all if given '*')'
                                                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
from sourcing file /home/linuxbrew/.linuxbrew/share/fish/vendor_completions.d/gum.fish
        called on line 8 of file ~/.config/fish/config.fish
from sourcing file ~/.config/fish/config.fish
        called during startup
🐟

Desktop (please complete the following information):

• Debian 12

Additional context
I looked around the completion generation code in the repo but can't pinpoint exactly what changed or where a fix could be performed. I'm not terribly familiar with the codebase.

[nate-duke]

I ran this down the the following two PRs

#777
#769

[bashbunni]

Hey @nate-duke looking into the issue further - I was able to get the same output in fish as you listed above, but when I replaced your outer single quotes with double quotes, I don't get an error.

complete -c gum -f -n "__fish_seen_subcommand_from choose" -x -l selected -d "Options that should start as selected (selects all if given '*')"

Can you please let me know if this command works as expected for you? Thanks!

[nate-duke]

yes @bashbunni that works. That's exactly what i did to make my shell load without error. I just wasn't certain what would have to be done in the source e.g:

gum/filter/options.go

Line 18 in 3745655

Selected []string `help:"Options that should start as selected (selects all if given '*')" default:"" env:"GUM_FILTER_SELECTED"`

to result in double quotes in the generated completion files.

Also, to be clear the use of the asterisk in those two places in the referenced pull requests are problematic, at least for the generated fish shell completions.

[nate-duke]

thanks @raphamorim!

could you take a look at

gum/choose/options.go

Line 23 in bb9fee7

Selected []string `help:"Options that should start as selected (selects all if given '*')" default:"" env:"GUM_CHOOSE_SELECTED"`

too? it's basically the same issue.

[raphamorim]

Sure! Will do a PR, thank you @nate-duke