Implement Pylint #970

charliermarsh · 2022-11-30T04:52:53Z

This is the parent issue for tracking parity with Pylint. Below, we've enumerated all Pylint rules.

Rules that are checked off have been implemented in Ruff already (either as a Pylint rule, e.g., PLE0237, or by way of overlap with another linter like Pyflakes, as with missing-format-string-key).

Rules that are crossed out have been removed some consideration. (In most cases, crossed-out rules represent Pylint specific rules, e.g., rules related to Pylint configuration.)

At time of writing, many of the remaining rules require type inference and/or multi-file analysis, and aren't ready to be implemented in Ruff. (See: #970 (comment) for an enumeration.) If you're looking to start work on a specific rule, I'd suggest commenting in the issue, to get some input on whether Ruff is capable of supporting it at present.

For guidance on getting started, see the Contributing documentation.

Note: Don't implement rules that are part of Pylint extension until #1774 is completed. Don't implement rules that mainly target Python 2.

Error

Warning

Convention

Refactor

The text was updated successfully, but these errors were encountered:

charliermarsh · 2022-11-30T05:26:33Z

Need to figure out what the right "check code" approach is here. We could just start to put these under RUF. Or we could do PYE for "Pylint Error", and so on. Or we could use PYL for all of them. In either case, though, we have to allow four-digit codes, as opposed to our current three-digit codes.

JonathanPlasse · 2022-11-30T06:28:59Z

I vote for PYE as it would keep the same categories and the migration would be easier.

harupy · 2022-12-01T03:49:24Z

I'll work on unneeded-not this weekend.

relsunkaev · 2022-12-01T07:27:04Z

I would suggest PL as the pylint prefix (PLE -> PyLint Error). I think PYE might be a bit ambiguous with PYflakes, PYdocstyle, etc.

MartinBernstorff · 2022-12-01T09:33:12Z

Would absolutely love to see this happen. I know flake8 intentionally decided not to implement e.g. unexpected-keyword-arg because it required looking outside of the current file for imported functions.

I expect you've already considered this, and really hope this won't stop ruff from implementing it, but just wanted to raise it.

charliermarsh · 2022-12-01T15:22:58Z

@relsunkaev 👍 Went with PLE! The first code is checked in as PLE1142 (matching E1142 from Pylint).

charliermarsh · 2022-12-01T15:23:31Z

@MartinBernstorff - Definitely. The multi-file stuff will come, just not as quickly.

hmc-cs-mdrissi · 2022-12-08T02:41:23Z

Not sure if it should be separate issue, but looking at missing-function-docstring rule (C0116), pylint's version of it is different. It only requires that a function has docstring some in class hierarchy and does not require over-ridden methods to have a docstring. As an example,

class Foo:
  def validate(self):
    """Doc."""
    ...

class Bar(Foo):
  def validate(self):
    ...

gives no errors in pylint even though second validate is missing docstring being pylint allows inheriting one. This is very useful when implementing interface and the docstring would really be same for all things that subclass.

charliermarsh · 2023-01-05T18:53:47Z

I'd like to get pointless-statement, unnecessary-ellipsis, and unnecessary-pass in.

charliermarsh · 2023-01-05T19:20:12Z

Relevant source for defining a pointless-statement: https://github.com/PyCQA/pylint/blob/56121344f6c9c223d8e4477c0cdb58c46c840b4b/pylint/checkers/base/basic_checker.py#L447

thejcannon · 2023-01-12T16:08:49Z

A while ago I set out to find all the pylint codes make redundant by type checking.

Unfortunately that code got lost to the sands of time.

You might consider skipping those as type checking tools are very sophisticated, if you can do the effort of compiling that list

thejcannon · 2023-01-12T16:14:48Z

I've also thought very long and hard about the fact that pylint appears very sophisticated when it comes to types because it builds on astroid which works very hard to infer types based on code (pre-type-annotations)

Ideally ruff (or any modern linter) is type-aware to be as helpful as possible, but that requires either:

A Rust-implemented type checkers for Python. Short of a large company writing and maintaining this I doubt it'll keep up with the other big dogs
Having the type information be seeded to ruff. Aside from the overhead and protocol, this actually seems feasible.

dae · 2023-01-12T22:32:06Z

For what it's worth, the type awareness of pylint is the killer feature that keeps us using it in our project despite how painfully slow it is. Our first-party code is almost fully typed, and mypy is generally good at catching typing issues. We've found multiple instances where pylint caught an issue that mypy missed however - usually in third-party code with missing or incomplete type definitions, but occasionally also in our own code when mypy doesn't notice (eg due to the presence of __getattr__: python/mypy#6251).

thejcannon · 2023-01-12T22:41:02Z

Out of curiosity, have you tried pyright? It claims to have inference support for codebases that aren't fully typed.

dae · 2023-01-12T22:49:36Z

Mypy has a check_untyped_defs which sounds equivalent, and we use that. We currently rely on mypy's no_strict_optional which pyright has no equivalent to, so pyright is not currently usable on our codebase.

This PR adds [Pylint `R2004`](https://pylint.pycqa.org/en/latest/user_guide/messages/refactor/magic-value-comparison.html#magic-value-comparison-r2004) Feel free to suggest changes and additions, I have tried to maintain parity with the Pylint implementation [`magic_value.py`](https://github.com/PyCQA/pylint/blob/main/pylint/extensions/magic_value.py) See #970

## Summary - Implementation of [redefined-slots-in-subclass / W0244](https://pylint.readthedocs.io/en/latest/user_guide/messages/warning/redefined-slots-in-subclass.html). - Related to #970 --------- Co-authored-by: Akira Noda <[email protected]> Co-authored-by: dylwil3 <[email protected]>

…inting (#3703) - Current pylint setup in Hue was linting staged changes only by checking for 3 rules. - Also pylint is comparatively slow and GPL licensed. - Switching to ruff has its own perks which are mentioned on: https://docs.astral.sh/ruff/ and it's MIT licensed. - For starters, it's waaayyy faster, can auto-fix errors and work as both linter and formatter replacing a lot of latest packages (like a all-in-one solution). - It is also supporting pylint rules which is WIP: astral-sh/ruff#970 - Currently this PR only targets the minimal transition from pylint to ruff. Iteratively, we will extend the rules to improve the Hue codebase, add its pre-commit and play around auto-fixing errors capability. This will also help in making our codebase more PEP8 compliant. - Ruff still does not support pylint's `W0311(bad-indentation)` rule which was present earlier with pylint in Hue. We will update it later when the support lands in a future release. - Manually in local setup. (cherry picked from commit 264a267) (cherry picked from commit 8aa919d946ba8d49add26261a3789b7013ef8566) Change-Id: Ia5388cabfea5a2fa491738e86f2ce49e3dd0fe0a

ryanc-bs · 2025-03-12T16:34:27Z

hi, are there any plans on implementing the redefined-outer-name rule from pylint soon? Would find it useful as this can be a nasty source of bugs, for example in:

items = []
for i in range(10):
    items = get_new_items(i)  # shadowing outer variable name
    items.extend(items)

# items now only contains the results from the last iteration

InSyncWithFoo · 2025-03-12T16:37:39Z

@ryanc-bs There's #15903, but it only implements parts of the upstream rule (specifically, it won't emit any diagnostics for your example).

a1tus · 2025-03-24T14:02:43Z

@ryanc-bs There's #15903, but it only implements parts of the upstream rule (specifically, it won't emit any diagnostics for your example).

+1 for this rule, in our project it would be very useful for detecting accidental imports/global vars shadowing

ssbarnea · 2025-03-25T11:08:43Z

If I am not mistaken consider-using-re-compile appears to be missing and it should not be hard to implement. I should mention that pylint implementation is able to detect only re.search or re.match but not re.sub and the reality is that all 3 can benefit from it.

tusharsadhwani · 2025-03-25T12:57:51Z

@ssbarnea that sounds easy and useful, I'll take it up

vjurczenia · 2025-04-16T22:20:41Z

Hi, is anyone available to discuss implementing use-maxsplit-arg / C0207?

I decided to dive right into it here (if only to learn a bit more about Ruff), but got a little stuck when trying to imitate Pylint's behavior here which, to the best of my understanding, is what prevents the rule from triggering on just any function called split.

I'm thinking this may not be possible, but would appreciate confirmation from someone well-versed in the SemanticModel.

ntBre · 2025-04-17T17:22:23Z

Hi, is anyone available to discuss implementing use-maxsplit-arg / C0207?

I decided to dive right into it here (if only to learn a bit more about Ruff), but got a little stuck when trying to imitate Pylint's behavior here which, to the best of my understanding, is what prevents the rule from triggering on just any function called split.

I'm thinking this may not be possible, but would appreciate confirmation from someone well-versed in the SemanticModel.

has_builtin_binding comes to mind first for this, but I'm not sure it works on methods like str.split. An alternative could be to try resolving the type of the string with ResolvedPythonType or something like resolve_string_literal. I don't think you can override str.split, so if we know the method receiver is a str and the name is split, it should be safe to enforce the rule.

You can also look for other rules that operate on builtin method calls to see how they handle it, but I didn't find any obvious candidates in a quick search.

dylwil3 · 2025-04-17T18:04:59Z

I think the alternative suggestions is right and you just need to know whether you're looking at a string. Maybe is_string would do? It seems to be used here for bad-str-strip-call which is a similar sort of rule.

vjurczenia · 2025-04-17T22:20:14Z

Thanks @ntBre and @dylwil3, that did the trick! Your advice helped refine the test a bit too: I've added a test case for a class that inherits from str and overrides split. This shouldn't get flagged, and it doesn't.

As seen above, I've opened a PR with this change based on the instructions in the contribution guide. Please correct me if I'm wrong, but I assume now we simply wait until a maintainer decides to review. 🤞

charliermarsh added the rule Implementing or modifying a lint rule label Nov 30, 2022

charliermarsh mentioned this issue Nov 30, 2022

How does ruff compare to pylint? #689

Closed

charliermarsh mentioned this issue Nov 30, 2022

Implement await-outside-async / E1142 #972

Merged

charliermarsh added plugin Implementing a known but unsupported plugin and removed rule Implementing or modifying a lint rule labels Dec 31, 2022

sbdchd mentioned this issue Jan 2, 2023

Implement flake8-pie #1543

Closed

7 tasks

max0x53 mentioned this issue Jan 12, 2023

Implement PLR2004 (MagicValueComparison) #1828

Merged

davidorme mentioned this issue Jan 17, 2025

Repair model attribute typing and docstrings ImperialCollegeLondon/virtual_ecosystem#666

Closed

InSyncWithFoo mentioned this issue Feb 3, 2025

[pylint] Redefined outer names (PLW0621) #15903

Open

Apakottur mentioned this issue Feb 3, 2025

N815 does not enforce enums to be named IN_ALL_CAPS (pylint invalid-name) #15914

Closed

This comment has been minimized.

Sign in to view

dscorbett mentioned this issue Feb 16, 2025

T100 doesn’t flag sys.breakpointhook and sys.__breakpointhook__ #16189

Closed

nogitting mentioned this issue Feb 21, 2025

Parent issue for feature tracking? j178/prefligit#197

Open

NeilGirdhar mentioned this issue Mar 3, 2025

[syntax-errors] Type parameter lists before Python 3.12 #16479

Merged

This comment has been minimized.

Sign in to view

0xquark mentioned this issue Mar 14, 2025

Extend Pylint Rules in Ruff rucio/rucio#7499

Closed

davidsbatista mentioned this issue Mar 20, 2025

Update docstring and prevent name collisions deepset-ai/haystack#9078

Merged

BryanttV mentioned this issue Mar 25, 2025

feat: replace pycodestyle, isort and pylint with ruff openedx/openedx-filters#275

Open

13 tasks

carl-baillargeon mentioned this issue Apr 9, 2025

feat(anta): New AntaRunner class with limit concurrency aristanetworks/anta#680

Open

4 tasks

jankatins mentioned this issue Apr 15, 2025

Update to modern packaging mystor/git-revise#141

Merged

vjurczenia mentioned this issue Apr 17, 2025

[pylint] Implement missing-maxsplit-arg (PLC0207) #17454

Draft

opk12 mentioned this issue Apr 24, 2025

new rule - not calling super() in custom exception's __init__() #8579

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Pylint #970

Implement Pylint #970

charliermarsh commented Nov 30, 2022 •

edited by MichaReiser

Loading

charliermarsh commented Nov 30, 2022 •

edited

Loading

JonathanPlasse commented Nov 30, 2022

harupy commented Dec 1, 2022

relsunkaev commented Dec 1, 2022 •

edited

Loading

MartinBernstorff commented Dec 1, 2022

charliermarsh commented Dec 1, 2022

charliermarsh commented Dec 1, 2022

hmc-cs-mdrissi commented Dec 8, 2022

charliermarsh commented Jan 5, 2023

charliermarsh commented Jan 5, 2023

thejcannon commented Jan 12, 2023

thejcannon commented Jan 12, 2023

dae commented Jan 12, 2023 •

edited

Loading

thejcannon commented Jan 12, 2023

dae commented Jan 12, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ryanc-bs commented Mar 12, 2025 •

edited

Loading

InSyncWithFoo commented Mar 12, 2025 •

edited

Loading

a1tus commented Mar 24, 2025

ssbarnea commented Mar 25, 2025 •

edited

Loading

tusharsadhwani commented Mar 25, 2025

vjurczenia commented Apr 16, 2025

ntBre commented Apr 17, 2025

dylwil3 commented Apr 17, 2025

vjurczenia commented Apr 17, 2025

Implement Pylint #970

Implement Pylint #970

Comments

charliermarsh commented Nov 30, 2022 • edited by MichaReiser Loading

Error

Warning

Convention

Refactor

charliermarsh commented Nov 30, 2022 • edited Loading

JonathanPlasse commented Nov 30, 2022

harupy commented Dec 1, 2022

relsunkaev commented Dec 1, 2022 • edited Loading

MartinBernstorff commented Dec 1, 2022

charliermarsh commented Dec 1, 2022

charliermarsh commented Dec 1, 2022

hmc-cs-mdrissi commented Dec 8, 2022

charliermarsh commented Jan 5, 2023

charliermarsh commented Jan 5, 2023

thejcannon commented Jan 12, 2023

thejcannon commented Jan 12, 2023

dae commented Jan 12, 2023 • edited Loading

thejcannon commented Jan 12, 2023

dae commented Jan 12, 2023

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ryanc-bs commented Mar 12, 2025 • edited Loading

InSyncWithFoo commented Mar 12, 2025 • edited Loading

a1tus commented Mar 24, 2025

ssbarnea commented Mar 25, 2025 • edited Loading

tusharsadhwani commented Mar 25, 2025

vjurczenia commented Apr 16, 2025

ntBre commented Apr 17, 2025

dylwil3 commented Apr 17, 2025

vjurczenia commented Apr 17, 2025

charliermarsh commented Nov 30, 2022 •

edited by MichaReiser

Loading

charliermarsh commented Nov 30, 2022 •

edited

Loading

relsunkaev commented Dec 1, 2022 •

edited

Loading

dae commented Jan 12, 2023 •

edited

Loading

ryanc-bs commented Mar 12, 2025 •

edited

Loading

InSyncWithFoo commented Mar 12, 2025 •

edited

Loading

ssbarnea commented Mar 25, 2025 •

edited

Loading